* [PATCH] crypto: remove unneeded semicolon
@ 2019-12-16 10:58 Chen Zhou
2019-12-16 18:43 ` Eric Biggers
2019-12-27 10:36 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Chen Zhou @ 2019-12-16 10:58 UTC (permalink / raw)
To: herbert, davem; +Cc: linux-crypto, linux-kernel, chenzhou10
Fixes coccicheck warning:
./include/linux/crypto.h:573:2-3: Unneeded semicolon
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
include/linux/crypto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/crypto.h b/include/linux/crypto.h
index 23365a9..5446efe 100644
--- a/include/linux/crypto.h
+++ b/include/linux/crypto.h
@@ -570,7 +570,7 @@ static inline int crypto_wait_req(int err, struct crypto_wait *wait)
reinit_completion(&wait->completion);
err = wait->err;
break;
- };
+ }
return err;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: remove unneeded semicolon
2019-12-16 10:58 [PATCH] crypto: remove unneeded semicolon Chen Zhou
@ 2019-12-16 18:43 ` Eric Biggers
2019-12-27 10:36 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2019-12-16 18:43 UTC (permalink / raw)
To: Chen Zhou; +Cc: herbert, davem, linux-crypto, linux-kernel
On Mon, Dec 16, 2019 at 06:58:48PM +0800, Chen Zhou wrote:
> Fixes coccicheck warning:
>
> ./include/linux/crypto.h:573:2-3: Unneeded semicolon
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> include/linux/crypto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index 23365a9..5446efe 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -570,7 +570,7 @@ static inline int crypto_wait_req(int err, struct crypto_wait *wait)
> reinit_completion(&wait->completion);
> err = wait->err;
> break;
> - };
> + }
>
> return err;
> }
> --
As long as you're changing this, perhaps also change the 'switch' to an 'if' and
delete the extra blank line? I.e.:
static inline int crypto_wait_req(int err, struct crypto_wait *wait)
{
if (err == -EINPROGRESS || err == -EBUSY) {
wait_for_completion(&wait->completion);
reinit_completion(&wait->completion);
err = wait->err;
}
return err;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: remove unneeded semicolon
2019-12-16 10:58 [PATCH] crypto: remove unneeded semicolon Chen Zhou
2019-12-16 18:43 ` Eric Biggers
@ 2019-12-27 10:36 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-12-27 10:36 UTC (permalink / raw)
To: Chen Zhou; +Cc: davem, linux-crypto, linux-kernel
On Mon, Dec 16, 2019 at 06:58:48PM +0800, Chen Zhou wrote:
> Fixes coccicheck warning:
>
> ./include/linux/crypto.h:573:2-3: Unneeded semicolon
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> include/linux/crypto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-27 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 10:58 [PATCH] crypto: remove unneeded semicolon Chen Zhou
2019-12-16 18:43 ` Eric Biggers
2019-12-27 10:36 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).