* [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
@ 2019-12-10 19:51 Arnd Bergmann
2019-12-11 9:14 ` Bartosz Golaszewski
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Arnd Bergmann @ 2019-12-10 19:51 UTC (permalink / raw)
To: Sekhar Nori
Cc: Arnd Bergmann, stable, Bartosz Golaszewski, Philipp Zabel,
David Lechner, linux-arm-kernel, linux-kernel
Selecting RESET_CONTROLLER is actually required, otherwise we
can get a link failure in the clock driver:
drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
Cc: <stable@vger.kernel.org> # v5.4
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-davinci/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index dd427bd2768c..02b180ad7245 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI
select PM_GENERIC_DOMAINS if PM
select PM_GENERIC_DOMAINS_OF if PM && OF
select REGMAP_MMIO
+ select RESET_CONTROLLER
select HAVE_IDE
select PINCTRL_SINGLE
--
2.20.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-10 19:51 [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Arnd Bergmann
@ 2019-12-11 9:14 ` Bartosz Golaszewski
2019-12-11 10:00 ` Philipp Zabel
2019-12-11 10:12 ` Sekhar Nori
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was " Pavel Machek
2 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-12-11 9:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sekhar Nori, Stable # 4 . 20+,
Philipp Zabel, David Lechner, arm-soc, LKML
wt., 10 gru 2019 o 20:52 Arnd Bergmann <arnd@arndb.de> napisał(a):
>
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Cc: <stable@vger.kernel.org> # v5.4
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-11 9:14 ` Bartosz Golaszewski
@ 2019-12-11 10:00 ` Philipp Zabel
0 siblings, 0 replies; 9+ messages in thread
From: Philipp Zabel @ 2019-12-11 10:00 UTC (permalink / raw)
To: Bartosz Golaszewski, Arnd Bergmann
Cc: Sekhar Nori, Stable # 4 . 20+, David Lechner, arm-soc, LKML
On Wed, 2019-12-11 at 10:14 +0100, Bartosz Golaszewski wrote:
> wt., 10 gru 2019 o 20:52 Arnd Bergmann <arnd@arndb.de> napisał(a):
> > Selecting RESET_CONTROLLER is actually required, otherwise we
> > can get a link failure in the clock driver:
> >
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
> >
> > Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> > Cc: <stable@vger.kernel.org> # v5.4
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > arch/arm/mach-davinci/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-10 19:51 [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Arnd Bergmann
2019-12-11 9:14 ` Bartosz Golaszewski
@ 2019-12-11 10:12 ` Sekhar Nori
2020-01-13 12:02 ` Sekhar Nori
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was " Pavel Machek
2 siblings, 1 reply; 9+ messages in thread
From: Sekhar Nori @ 2019-12-11 10:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: stable, Bartosz Golaszewski, Philipp Zabel, David Lechner,
linux-arm-kernel, linux-kernel
Hi Arnd,
On 11/12/19 1:21 AM, Arnd Bergmann wrote:
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Cc: <stable@vger.kernel.org> # v5.4
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Assuming you are going to apply directly to ARM-SoC,
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
> ---
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index dd427bd2768c..02b180ad7245 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> select REGMAP_MMIO
> + select RESET_CONTROLLER
> select HAVE_IDE
> select PINCTRL_SINGLE
>
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-11 10:12 ` Sekhar Nori
@ 2020-01-13 12:02 ` Sekhar Nori
2020-01-16 18:34 ` Olof Johansson
0 siblings, 1 reply; 9+ messages in thread
From: Sekhar Nori @ 2020-01-13 12:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: stable, Bartosz Golaszewski, Philipp Zabel, David Lechner,
linux-arm-kernel, linux-kernel
Hi Arnd,
On 11/12/19 3:42 PM, Sekhar Nori wrote:
> Hi Arnd,
>
> On 11/12/19 1:21 AM, Arnd Bergmann wrote:
>> Selecting RESET_CONTROLLER is actually required, otherwise we
>> can get a link failure in the clock driver:
>>
>> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
>> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
>> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
>> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>>
>> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
>> Cc: <stable@vger.kernel.org> # v5.4
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Assuming you are going to apply directly to ARM-SoC,
>
> Acked-by: Sekhar Nori <nsekhar@ti.com>
This is not yet in Linus's master. Let me know if I should collect it
and send a pull request.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2020-01-13 12:02 ` Sekhar Nori
@ 2020-01-16 18:34 ` Olof Johansson
0 siblings, 0 replies; 9+ messages in thread
From: Olof Johansson @ 2020-01-16 18:34 UTC (permalink / raw)
To: Sekhar Nori
Cc: Arnd Bergmann, David Lechner, linux-kernel, stable,
Bartosz Golaszewski, Philipp Zabel, linux-arm-kernel
On Mon, Jan 13, 2020 at 05:32:54PM +0530, Sekhar Nori wrote:
> Hi Arnd,
>
> On 11/12/19 3:42 PM, Sekhar Nori wrote:
> > Hi Arnd,
> >
> > On 11/12/19 1:21 AM, Arnd Bergmann wrote:
> >> Selecting RESET_CONTROLLER is actually required, otherwise we
> >> can get a link failure in the clock driver:
> >>
> >> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> >> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> >> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> >> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
> >>
> >> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> >> Cc: <stable@vger.kernel.org> # v5.4
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Assuming you are going to apply directly to ARM-SoC,
> >
> > Acked-by: Sekhar Nori <nsekhar@ti.com>
>
> This is not yet in Linus's master. Let me know if I should collect it
> and send a pull request.
It's sitting in our fixes branch and should show up in mainline in not too
long.
-Olof
^ permalink raw reply [flat|nested] 9+ messages in thread
* TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-10 19:51 [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Arnd Bergmann
2019-12-11 9:14 ` Bartosz Golaszewski
2019-12-11 10:12 ` Sekhar Nori
@ 2019-12-17 10:45 ` Pavel Machek
2019-12-17 16:46 ` Tony Lindgren
2 siblings, 1 reply; 9+ messages in thread
From: Pavel Machek @ 2019-12-17 10:45 UTC (permalink / raw)
To: Arnd Bergmann, kernel list, linux-arm-kernel, linux-omap, tony,
sre, nekit1000, mpartap, merlijn, martin_rysavy
Cc: Sekhar Nori, stable, Bartosz Golaszewski, Philipp Zabel,
David Lechner, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Hi!
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to
> `reset_controller_add_lookup'
Does omap need similar handing in 5.5-rc1?
LD .tmp_vmlinux1
drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
omap_prm.c:(.text+0x4d0): undefined reference to
`devm_reset_controller_register'
/data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
make[1]: *** [vmlinux] Error 1
Enabling reset controller seems to help::
Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)
Best regards,
Pavel
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was " Pavel Machek
@ 2019-12-17 16:46 ` Tony Lindgren
2019-12-21 16:20 ` Pavel Machek
0 siblings, 1 reply; 9+ messages in thread
From: Tony Lindgren @ 2019-12-17 16:46 UTC (permalink / raw)
To: Pavel Machek
Cc: Arnd Bergmann, kernel list, linux-arm-kernel, linux-omap, sre,
nekit1000, mpartap, merlijn, martin_rysavy, Sekhar Nori, stable,
Bartosz Golaszewski, Philipp Zabel, David Lechner
* Pavel Machek <pavel@ucw.cz> [191217 10:46]:
> Hi!
>
> > Selecting RESET_CONTROLLER is actually required, otherwise we
> > can get a link failure in the clock driver:
> >
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x24): undefined reference to
> > `reset_controller_add_lookup'
>
> Does omap need similar handing in 5.5-rc1?
>
> LD .tmp_vmlinux1
> drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
> omap_prm.c:(.text+0x4d0): undefined reference to
> `devm_reset_controller_register'
> /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
> make[1]: *** [vmlinux] Error 1
>
> Enabling reset controller seems to help::
>
> Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
> TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)
Yes see the patch Arnd recently posted to do that.
Regards,
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
2019-12-17 16:46 ` Tony Lindgren
@ 2019-12-21 16:20 ` Pavel Machek
0 siblings, 0 replies; 9+ messages in thread
From: Pavel Machek @ 2019-12-21 16:20 UTC (permalink / raw)
To: Tony Lindgren
Cc: Arnd Bergmann, kernel list, linux-arm-kernel, linux-omap, sre,
nekit1000, mpartap, merlijn, martin_rysavy, Sekhar Nori, stable,
Bartosz Golaszewski, Philipp Zabel, David Lechner
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
Hi!
> > > Selecting RESET_CONTROLLER is actually required, otherwise we
> > > can get a link failure in the clock driver:
> > >
> > > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > > psc-da850.c:(.text+0x24): undefined reference to
> > > `reset_controller_add_lookup'
> >
> > Does omap need similar handing in 5.5-rc1?
> >
> > LD .tmp_vmlinux1
> > drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
> > omap_prm.c:(.text+0x4d0): undefined reference to
> > `devm_reset_controller_register'
> > /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
> > make[1]: *** [vmlinux] Error 1
> >
> > Enabling reset controller seems to help::
> >
> > Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
> > TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)
>
> Yes see the patch Arnd recently posted to do that.
Thanks for the hint and sorry for the noise.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-16 18:35 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 19:51 [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Arnd Bergmann
2019-12-11 9:14 ` Bartosz Golaszewski
2019-12-11 10:00 ` Philipp Zabel
2019-12-11 10:12 ` Sekhar Nori
2020-01-13 12:02 ` Sekhar Nori
2020-01-16 18:34 ` Olof Johansson
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was " Pavel Machek
2019-12-17 16:46 ` Tony Lindgren
2019-12-21 16:20 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).