linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: [PATCH v2 07/11] firmware: arm_scmi: Skip protocol initialisation for additional devices
Date: Wed, 18 Dec 2019 11:17:38 +0000	[thread overview]
Message-ID: <20191218111742.29731-8-sudeep.holla@arm.com> (raw)
In-Reply-To: <20191218111742.29731-1-sudeep.holla@arm.com>

The scmi bus now supports adding multiple devices per protocol,
and since scmi_protocol_init is called for each scmi device created,
we must avoid allocating protocol private data and initialising the
protocol itself if it is already initialised.

In order to achieve the same, we can simple replace the idr pointer
from protocol initialisation function to a dummy function.

Suggested-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/firmware/arm_scmi/bus.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
index 3714e6307b05..db55c43a2cbd 100644
--- a/drivers/firmware/arm_scmi/bus.c
+++ b/drivers/firmware/arm_scmi/bus.c
@@ -60,6 +60,11 @@ static int scmi_protocol_init(int protocol_id, struct scmi_handle *handle)
 	return fn(handle);
 }
 
+static int scmi_protocol_dummy_init(struct scmi_handle *handle)
+{
+	return 0;
+}
+
 static int scmi_dev_probe(struct device *dev)
 {
 	struct scmi_driver *scmi_drv = to_scmi_driver(dev->driver);
@@ -78,6 +83,10 @@ static int scmi_dev_probe(struct device *dev)
 	if (ret)
 		return ret;
 
+	/* Skip protocol initialisation for additional devices */
+	idr_replace(&scmi_protocols, &scmi_protocol_dummy_init,
+		    scmi_dev->protocol_id);
+
 	return scmi_drv->probe(scmi_dev);
 }
 
-- 
2.17.1


  parent reply	other threads:[~2019-12-18 11:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 11:17 [PATCH v2 00/11] firmware: arm_scmi: Add support for multiple device per protocol Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 01/11] " Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 02/11] firmware: arm_scmi: Skip scmi mbox channel setup for addtional devices Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 03/11] firmware: arm_scmi: Add names to scmi devices created Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 04/11] firmware: arm_scmi: Add versions and identifier attributes using dev_groups Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 05/11] firmware: arm_scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 06/11] firmware: arm_scmi: Stash version in protocol init functions Sudeep Holla
2019-12-18 11:17 ` Sudeep Holla [this message]
2019-12-24 14:33   ` [PATCH v2 07/11] firmware: arm_scmi: Skip protocol initialisation for additional devices Sudeep Holla
2019-12-24 14:35     ` Cristian Marussi
2019-12-18 11:17 ` [PATCH v2 08/11] clk: scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-26 22:04   ` Stephen Boyd
2019-12-18 11:17 ` [PATCH v2 09/11] cpufreq: " Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 10/11] hwmon: (scmi-hwmon) " Sudeep Holla
2020-01-04 16:19   ` Guenter Roeck
2020-01-06 10:39     ` Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 11/11] reset: reset-scmi: " Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218111742.29731-8-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).