linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/11] firmware: arm_scmi: Skip protocol initialisation for additional devices
Date: Tue, 24 Dec 2019 14:35:27 +0000	[thread overview]
Message-ID: <4113a9cf-650c-e086-fcd9-b126da1597eb@arm.com> (raw)
In-Reply-To: <CAPKp9uZznwOgpm=CEMMUDFvHVa=jsmG0-fd4q-_=c_d3HqbKTA@mail.gmail.com>

Hi

On 24/12/2019 14:33, Sudeep Holla wrote:
> On Wed, Dec 18, 2019 at 11:19 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>> The scmi bus now supports adding multiple devices per protocol,
>> and since scmi_protocol_init is called for each scmi device created,
>> we must avoid allocating protocol private data and initialising the
>> protocol itself if it is already initialised.
>>
>> In order to achieve the same, we can simple replace the idr pointer
>> from protocol initialisation function to a dummy function.
>>
>> Suggested-by: Cristian Marussi <cristian.marussi@arm.com>
> 
> 
> Hi Cristian,
> 
> Are you fine with this approach ? If yes, I plan to apply this series.
> 

Yes sure...forgot this was pending.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Cristian
> --
> Regards,
> Sudeep
> 


  reply	other threads:[~2019-12-24 14:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 11:17 [PATCH v2 00/11] firmware: arm_scmi: Add support for multiple device per protocol Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 01/11] " Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 02/11] firmware: arm_scmi: Skip scmi mbox channel setup for addtional devices Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 03/11] firmware: arm_scmi: Add names to scmi devices created Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 04/11] firmware: arm_scmi: Add versions and identifier attributes using dev_groups Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 05/11] firmware: arm_scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 06/11] firmware: arm_scmi: Stash version in protocol init functions Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 07/11] firmware: arm_scmi: Skip protocol initialisation for additional devices Sudeep Holla
2019-12-24 14:33   ` Sudeep Holla
2019-12-24 14:35     ` Cristian Marussi [this message]
2019-12-18 11:17 ` [PATCH v2 08/11] clk: scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-26 22:04   ` Stephen Boyd
2019-12-18 11:17 ` [PATCH v2 09/11] cpufreq: " Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 10/11] hwmon: (scmi-hwmon) " Sudeep Holla
2020-01-04 16:19   ` Guenter Roeck
2020-01-06 10:39     ` Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 11/11] reset: reset-scmi: " Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4113a9cf-650c-e086-fcd9-b126da1597eb@arm.com \
    --to=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).