* [PATCH] NFC: pn544: Adjust indentation in pn544_hci_check_presence
@ 2019-12-18 1:21 Nathan Chancellor
2019-12-20 2:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2019-12-18 1:21 UTC (permalink / raw)
To: David S. Miller
Cc: netdev, linux-kernel, clang-built-linux, Nathan Chancellor
Clang warns
../drivers/nfc/pn544/pn544.c:696:4: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
return nfc_hci_send_cmd(hdev, NFC_HCI_RF_READER_A_GATE,
^
../drivers/nfc/pn544/pn544.c:692:3: note: previous statement is here
if (target->nfcid1_len != 4 && target->nfcid1_len != 7 &&
^
1 warning generated.
This warning occurs because there is a space after the tab on this line.
Remove it so that the indentation is consistent with the Linux kernel
coding style and clang no longer warns.
Fixes: da052850b911 ("NFC: Add pn544 presence check for different targets")
Link: https://github.com/ClangBuiltLinux/linux/issues/814
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/nfc/pn544/pn544.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/pn544/pn544.c b/drivers/nfc/pn544/pn544.c
index cda996f6954e..2b83156efe3f 100644
--- a/drivers/nfc/pn544/pn544.c
+++ b/drivers/nfc/pn544/pn544.c
@@ -693,7 +693,7 @@ static int pn544_hci_check_presence(struct nfc_hci_dev *hdev,
target->nfcid1_len != 10)
return -EOPNOTSUPP;
- return nfc_hci_send_cmd(hdev, NFC_HCI_RF_READER_A_GATE,
+ return nfc_hci_send_cmd(hdev, NFC_HCI_RF_READER_A_GATE,
PN544_RF_READER_CMD_ACTIVATE_NEXT,
target->nfcid1, target->nfcid1_len, NULL);
} else if (target->supported_protocols & (NFC_PROTO_JEWEL_MASK |
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFC: pn544: Adjust indentation in pn544_hci_check_presence
2019-12-18 1:21 [PATCH] NFC: pn544: Adjust indentation in pn544_hci_check_presence Nathan Chancellor
@ 2019-12-20 2:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-20 2:14 UTC (permalink / raw)
To: natechancellor; +Cc: netdev, linux-kernel, clang-built-linux
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Tue, 17 Dec 2019 18:21:52 -0700
> Clang warns
>
> ../drivers/nfc/pn544/pn544.c:696:4: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
> return nfc_hci_send_cmd(hdev, NFC_HCI_RF_READER_A_GATE,
> ^
> ../drivers/nfc/pn544/pn544.c:692:3: note: previous statement is here
> if (target->nfcid1_len != 4 && target->nfcid1_len != 7 &&
> ^
> 1 warning generated.
>
> This warning occurs because there is a space after the tab on this line.
> Remove it so that the indentation is consistent with the Linux kernel
> coding style and clang no longer warns.
>
> Fixes: da052850b911 ("NFC: Add pn544 presence check for different targets")
> Link: https://github.com/ClangBuiltLinux/linux/issues/814
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-20 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 1:21 [PATCH] NFC: pn544: Adjust indentation in pn544_hci_check_presence Nathan Chancellor
2019-12-20 2:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).