* [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue
@ 2019-12-19 9:05 Simran Sandhu
2019-12-19 9:35 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Simran Sandhu @ 2019-12-19 9:05 UTC (permalink / raw)
To: gregkh; +Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
Fixed the checkpath error: function definition arguments
should also have identifier names
Signed-of-by: Simran Sandhu <f20171454@hyderabad.bits-pilani.ac.in>
---
drivers/staging/sm750fb/sm750.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index ce90adcb449d..cf986bad7210 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -66,9 +66,9 @@ struct lynx_accel {
u32, u32, u32, u32,
u32, u32, u32, u32);
- int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32,
- u32, u32, u32, u32,
- u32, u32, u32, u32);
+ int (*de_imageblit)(struct lynx_accel *A, const char *B, u32 C, u32 D,
+ u32 E, u32 F, u32 G, u32 H, u32 I,
+ u32 J, u32 K, u32 L, u32 M, u32 N);
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue
2019-12-19 9:05 [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue Simran Sandhu
@ 2019-12-19 9:35 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-12-19 9:35 UTC (permalink / raw)
To: Simran Sandhu
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Thu, Dec 19, 2019 at 02:35:53PM +0530, Simran Sandhu wrote:
> Fixed the checkpath error: function definition arguments
> should also have identifier names
>
> Signed-of-by: Simran Sandhu <f20171454@hyderabad.bits-pilani.ac.in>
> ---
> drivers/staging/sm750fb/sm750.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index ce90adcb449d..cf986bad7210 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -66,9 +66,9 @@ struct lynx_accel {
> u32, u32, u32, u32,
> u32, u32, u32, u32);
>
> - int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32,
> - u32, u32, u32, u32,
> - u32, u32, u32, u32);
> + int (*de_imageblit)(struct lynx_accel *A, const char *B, u32 C, u32 D,
> + u32 E, u32 F, u32 G, u32 H, u32 I,
> + u32 J, u32 K, u32 L, u32 M, u32 N);
>
You just caused another coding style violation with this one :(
Always run your patches though checkpatch.pl to ensure you do not add
new problems when trying to fix up things.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 9:05 [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue Simran Sandhu
2019-12-19 9:35 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).