* [PATCH] media: media/saa7146: fix incorrect assertion in saa7146_buffer_finish
@ 2019-12-19 20:29 Aditya Pakki
0 siblings, 0 replies; only message in thread
From: Aditya Pakki @ 2019-12-19 20:29 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Hans Verkuil, Mauro Carvalho Chehab, linux-media, linux-kernel
In saa7146_buffer_finish, the code for q->curr to be NULL is
already present and asserting for NULL is unnecessary. This patch
elimiates such a check.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/media/common/saa7146/saa7146_fops.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/common/saa7146/saa7146_fops.c
index aabb830e7468..d7e83b55ddca 100644
--- a/drivers/media/common/saa7146/saa7146_fops.c
+++ b/drivers/media/common/saa7146/saa7146_fops.c
@@ -97,8 +97,6 @@ void saa7146_buffer_finish(struct saa7146_dev *dev,
DEB_EE("dev:%p, dmaq:%p, state:%d\n", dev, q, state);
DEB_EE("q->curr:%p\n", q->curr);
- BUG_ON(!q->curr);
-
/* finish current buffer */
if (NULL == q->curr) {
DEB_D("aiii. no current buffer\n");
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-19 20:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 20:29 [PATCH] media: media/saa7146: fix incorrect assertion in saa7146_buffer_finish Aditya Pakki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).