From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-pm@vger.kernel.org, evgreen@chromium.org,
daidavid1@codeaurora.org, okukatla@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: Print the tag in the debugfs summary
Date: Fri, 20 Dec 2019 08:51:13 -0800 [thread overview]
Message-ID: <20191220165113.GB549437@yoga> (raw)
In-Reply-To: <20191220163846.6485-1-georgi.djakov@linaro.org>
On Fri 20 Dec 08:38 PST 2019, Georgi Djakov wrote:
> Now we can have a tag associated with the path. Add this information
> to the interconnect_summary file, as the current information in debugfs
> is incomplete.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/interconnect/core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 1867fad56c0f..ae80fbea5d2d 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -34,7 +34,7 @@ static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
> if (!n)
> return;
>
> - seq_printf(s, "%-30s %12u %12u\n",
> + seq_printf(s, "%-42s %12u %12u\n",
> n->name, n->avg_bw, n->peak_bw);
> }
>
> @@ -42,8 +42,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
> {
> struct icc_provider *provider;
>
> - seq_puts(s, " node avg peak\n");
> - seq_puts(s, "--------------------------------------------------------\n");
> + seq_puts(s, " node tag avg peak\n");
> + seq_puts(s, "--------------------------------------------------------------------\n");
>
> mutex_lock(&icc_lock);
>
> @@ -58,8 +58,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
> if (!r->dev)
> continue;
>
> - seq_printf(s, " %-26s %12u %12u\n",
> - dev_name(r->dev), r->avg_bw,
> + seq_printf(s, " %-27s %12u %12u %12u\n",
> + dev_name(r->dev), r->tag, r->avg_bw,
> r->peak_bw);
> }
> }
prev parent reply other threads:[~2019-12-20 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 16:38 [PATCH] interconnect: Print the tag in the debugfs summary Georgi Djakov
2019-12-20 16:51 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220165113.GB549437@yoga \
--to=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).