linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] interconnect: Print the tag in the debugfs summary
@ 2019-12-20 16:38 Georgi Djakov
  2019-12-20 16:51 ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Georgi Djakov @ 2019-12-20 16:38 UTC (permalink / raw)
  To: linux-pm
  Cc: bjorn.andersson, evgreen, daidavid1, okukatla, georgi.djakov,
	linux-kernel

Now we can have a tag associated with the path. Add this information
to the interconnect_summary file, as the current information in debugfs
is incomplete.

Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
 drivers/interconnect/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 1867fad56c0f..ae80fbea5d2d 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -34,7 +34,7 @@ static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
 	if (!n)
 		return;
 
-	seq_printf(s, "%-30s %12u %12u\n",
+	seq_printf(s, "%-42s %12u %12u\n",
 		   n->name, n->avg_bw, n->peak_bw);
 }
 
@@ -42,8 +42,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
 {
 	struct icc_provider *provider;
 
-	seq_puts(s, " node                                   avg         peak\n");
-	seq_puts(s, "--------------------------------------------------------\n");
+	seq_puts(s, " node                                  tag          avg         peak\n");
+	seq_puts(s, "--------------------------------------------------------------------\n");
 
 	mutex_lock(&icc_lock);
 
@@ -58,8 +58,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
 				if (!r->dev)
 					continue;
 
-				seq_printf(s, "    %-26s %12u %12u\n",
-					   dev_name(r->dev), r->avg_bw,
+				seq_printf(s, "  %-27s %12u %12u %12u\n",
+					   dev_name(r->dev), r->tag, r->avg_bw,
 					   r->peak_bw);
 			}
 		}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] interconnect: Print the tag in the debugfs summary
  2019-12-20 16:38 [PATCH] interconnect: Print the tag in the debugfs summary Georgi Djakov
@ 2019-12-20 16:51 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-12-20 16:51 UTC (permalink / raw)
  To: Georgi Djakov; +Cc: linux-pm, evgreen, daidavid1, okukatla, linux-kernel

On Fri 20 Dec 08:38 PST 2019, Georgi Djakov wrote:

> Now we can have a tag associated with the path. Add this information
> to the interconnect_summary file, as the current information in debugfs
> is incomplete.
> 
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  drivers/interconnect/core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 1867fad56c0f..ae80fbea5d2d 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -34,7 +34,7 @@ static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
>  	if (!n)
>  		return;
>  
> -	seq_printf(s, "%-30s %12u %12u\n",
> +	seq_printf(s, "%-42s %12u %12u\n",
>  		   n->name, n->avg_bw, n->peak_bw);
>  }
>  
> @@ -42,8 +42,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
>  {
>  	struct icc_provider *provider;
>  
> -	seq_puts(s, " node                                   avg         peak\n");
> -	seq_puts(s, "--------------------------------------------------------\n");
> +	seq_puts(s, " node                                  tag          avg         peak\n");
> +	seq_puts(s, "--------------------------------------------------------------------\n");
>  
>  	mutex_lock(&icc_lock);
>  
> @@ -58,8 +58,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
>  				if (!r->dev)
>  					continue;
>  
> -				seq_printf(s, "    %-26s %12u %12u\n",
> -					   dev_name(r->dev), r->avg_bw,
> +				seq_printf(s, "  %-27s %12u %12u %12u\n",
> +					   dev_name(r->dev), r->tag, r->avg_bw,
>  					   r->peak_bw);
>  			}
>  		}

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-20 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 16:38 [PATCH] interconnect: Print the tag in the debugfs summary Georgi Djakov
2019-12-20 16:51 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).