From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mao Wenan <maowenan@huawei.com>
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, linux@rempel-privat.de, marek.behun@nic.cz,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init
Date: Tue, 24 Dec 2019 13:10:10 +0100 [thread overview]
Message-ID: <20191224121010.o5ezcorzix5kfjns@pengutronix.de> (raw)
In-Reply-To: <20191224115812.166927-1-maowenan@huawei.com>
Hi,
On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote:
> There is no need to set variable 'mbus' static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> v2: change subject and description.
> drivers/net/dsa/qca/ar9331.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
> index 0d1a7cd85fe8..da3bece75e21 100644
> --- a/drivers/net/dsa/qca/ar9331.c
> +++ b/drivers/net/dsa/qca/ar9331.c
> @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum)
> static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv)
> {
> struct device *dev = priv->dev;
> - static struct mii_bus *mbus;
> + struct mii_bus *mbus;
> struct device_node *np, *mnp;
> int ret;
>
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2019-12-24 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 2:40 [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init Mao Wenan
2019-12-24 10:45 ` Marek Behun
2019-12-24 11:25 ` Andrew Lunn
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel [this message]
2019-12-24 12:34 ` Andrew Lunn
2019-12-28 0:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224121010.o5ezcorzix5kfjns@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=maowenan@huawei.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).