* [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init
@ 2019-12-24 2:40 Mao Wenan
2019-12-24 10:45 ` Marek Behun
2019-12-24 11:25 ` Andrew Lunn
0 siblings, 2 replies; 7+ messages in thread
From: Mao Wenan @ 2019-12-24 2:40 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, davem, linux, maowenan
Cc: netdev, linux-kernel, kernel-janitors
There is no need to have the 'T *v' variable static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/net/dsa/qca/ar9331.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
index 0d1a7cd85fe8..da3bece75e21 100644
--- a/drivers/net/dsa/qca/ar9331.c
+++ b/drivers/net/dsa/qca/ar9331.c
@@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum)
static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv)
{
struct device *dev = priv->dev;
- static struct mii_bus *mbus;
+ struct mii_bus *mbus;
struct device_node *np, *mnp;
int ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init
2019-12-24 2:40 [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init Mao Wenan
@ 2019-12-24 10:45 ` Marek Behun
2019-12-24 11:25 ` Andrew Lunn
1 sibling, 0 replies; 7+ messages in thread
From: Marek Behun @ 2019-12-24 10:45 UTC (permalink / raw)
To: Mao Wenan
Cc: andrew, vivien.didelot, f.fainelli, davem, linux, netdev,
linux-kernel, kernel-janitors
Hi Mao,
the commit title should be something of the form
net: dsa: qca: ar9331: drop pointless static qualifier
or
net: dsa: ar9331: drop pointless static qualifier
If it begins only with
net: dsa:
then it makes people think you are changing stuff in main dsa code.
Marek
On Tue, 24 Dec 2019 10:40:59 +0800
Mao Wenan <maowenan@huawei.com> wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/net/dsa/qca/ar9331.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
> index 0d1a7cd85fe8..da3bece75e21 100644
> --- a/drivers/net/dsa/qca/ar9331.c
> +++ b/drivers/net/dsa/qca/ar9331.c
> @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum)
> static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv)
> {
> struct device *dev = priv->dev;
> - static struct mii_bus *mbus;
> + struct mii_bus *mbus;
> struct device_node *np, *mnp;
> int ret;
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init
2019-12-24 2:40 [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init Mao Wenan
2019-12-24 10:45 ` Marek Behun
@ 2019-12-24 11:25 ` Andrew Lunn
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Lunn @ 2019-12-24 11:25 UTC (permalink / raw)
To: Mao Wenan
Cc: vivien.didelot, f.fainelli, davem, linux, netdev, linux-kernel,
kernel-janitors
On Tue, Dec 24, 2019 at 10:40:59AM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
What does 'T *v' mean?
The patch itself looks O.K, but the description should be better, and
the subject line.
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init
2019-12-24 11:25 ` Andrew Lunn
@ 2019-12-24 11:58 ` Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mao Wenan @ 2019-12-24 11:58 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, davem, linux, maowenan, marek.behun
Cc: netdev, linux-kernel, kernel-janitors
There is no need to set variable 'mbus' static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v2: change subject and description.
drivers/net/dsa/qca/ar9331.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
index 0d1a7cd85fe8..da3bece75e21 100644
--- a/drivers/net/dsa/qca/ar9331.c
+++ b/drivers/net/dsa/qca/ar9331.c
@@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum)
static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv)
{
struct device *dev = priv->dev;
- static struct mii_bus *mbus;
+ struct mii_bus *mbus;
struct device_node *np, *mnp;
int ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
@ 2019-12-24 12:10 ` Oleksij Rempel
2019-12-24 12:34 ` Andrew Lunn
2019-12-28 0:32 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: Oleksij Rempel @ 2019-12-24 12:10 UTC (permalink / raw)
To: Mao Wenan
Cc: andrew, vivien.didelot, f.fainelli, davem, linux, marek.behun,
netdev, linux-kernel, kernel-janitors
Hi,
On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote:
> There is no need to set variable 'mbus' static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> v2: change subject and description.
> drivers/net/dsa/qca/ar9331.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
> index 0d1a7cd85fe8..da3bece75e21 100644
> --- a/drivers/net/dsa/qca/ar9331.c
> +++ b/drivers/net/dsa/qca/ar9331.c
> @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum)
> static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv)
> {
> struct device *dev = priv->dev;
> - static struct mii_bus *mbus;
> + struct mii_bus *mbus;
> struct device_node *np, *mnp;
> int ret;
>
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel
@ 2019-12-24 12:34 ` Andrew Lunn
2019-12-28 0:32 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2019-12-24 12:34 UTC (permalink / raw)
To: Mao Wenan
Cc: vivien.didelot, f.fainelli, davem, linux, marek.behun, netdev,
linux-kernel, kernel-janitors
On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote:
> There is no need to set variable 'mbus' static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel
2019-12-24 12:34 ` Andrew Lunn
@ 2019-12-28 0:32 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2019-12-28 0:32 UTC (permalink / raw)
To: maowenan
Cc: andrew, vivien.didelot, f.fainelli, linux, marek.behun, netdev,
linux-kernel, kernel-janitors
From: Mao Wenan <maowenan@huawei.com>
Date: Tue, 24 Dec 2019 19:58:12 +0800
> There is no need to set variable 'mbus' static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-28 0:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-24 2:40 [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init Mao Wenan
2019-12-24 10:45 ` Marek Behun
2019-12-24 11:25 ` Andrew Lunn
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel
2019-12-24 12:34 ` Andrew Lunn
2019-12-28 0:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).