From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Phil Auld <pauld@redhat.com>, Waiman Long <longman@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH] powerpc/shared: Fix build problem
Date: Thu, 26 Dec 2019 09:25:05 +0530 [thread overview]
Message-ID: <20191226035505.GB1781@linux.vnet.ibm.com> (raw)
In-Reply-To: <20191225160626.968-1-linux@roeck-us.net>
* Guenter Roeck <linux@roeck-us.net> [2019-12-25 08:06:26]:
> Since commit 656c21d6af5d ("powerpc/shared: Use static key to detect
> shared processor") and 14c73bd344da ("powerpc/vcpu: Assume dedicated
> processors as non-preempt"), powerpc test builds may fail with the
> following build errors.
>
> ./arch/powerpc/include/asm/spinlock.h:39:1: error:
> type defaults to ???int??? in declaration of ???DECLARE_STATIC_KEY_FALSE???
> ./arch/powerpc/include/asm/spinlock.h: In function ???vcpu_is_preempted???:
> ./arch/powerpc/include/asm/spinlock.h:44:7: error:
> implicit declaration of function ???static_branch_unlikely???
> ./arch/powerpc/include/asm/spinlock.h:44:31: error:
> ???shared_processor??? undeclared
>
> The offending commits use static_branch_unlikely and shared_processor
> without adding the include file declaring it.
Thanks for reporting but same fix was already posted
http://lkml.kernel.org/r/20191223133147.129983-1-Jason@zx2c4.com
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2019-12-26 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 16:06 [PATCH] powerpc/shared: Fix build problem Guenter Roeck
2019-12-26 3:55 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226035505.GB1781@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=pauld@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).