* [PATCH] powerpc/shared: Fix build problem
@ 2019-12-25 16:06 Guenter Roeck
2019-12-26 3:55 ` Srikar Dronamraju
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2019-12-25 16:06 UTC (permalink / raw)
To: Michael Ellerman
Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Benjamin Herrenschmidt,
Paul Mackerras, linux-kernel, linuxppc-dev, Guenter Roeck,
Srikar Dronamraju, Phil Auld, Waiman Long, Juri Lelli
Since commit 656c21d6af5d ("powerpc/shared: Use static key to detect
shared processor") and 14c73bd344da ("powerpc/vcpu: Assume dedicated
processors as non-preempt"), powerpc test builds may fail with the
following build errors.
./arch/powerpc/include/asm/spinlock.h:39:1: error:
type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’
./arch/powerpc/include/asm/spinlock.h: In function ‘vcpu_is_preempted’:
./arch/powerpc/include/asm/spinlock.h:44:7: error:
implicit declaration of function ‘static_branch_unlikely’
./arch/powerpc/include/asm/spinlock.h:44:31: error:
‘shared_processor’ undeclared
The offending commits use static_branch_unlikely and shared_processor
without adding the include file declaring it.
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Phil Auld <pauld@redhat.com>
Cc: Waiman Long <longman@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Juri Lelli <juri.lelli@redhat.com>
Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
Fixes: 14c73bd344da ("powerpc/vcpu: Assume dedicated processors as non-preempt")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/powerpc/include/asm/spinlock.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h
index 1b55fc08f853..5ddd48616b1c 100644
--- a/arch/powerpc/include/asm/spinlock.h
+++ b/arch/powerpc/include/asm/spinlock.h
@@ -16,6 +16,7 @@
* (the type definitions are in asm/spinlock_types.h)
*/
#include <linux/irqflags.h>
+#include <linux/jump_label.h>
#ifdef CONFIG_PPC64
#include <asm/paca.h>
#include <asm/hvcall.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/shared: Fix build problem
2019-12-25 16:06 [PATCH] powerpc/shared: Fix build problem Guenter Roeck
@ 2019-12-26 3:55 ` Srikar Dronamraju
0 siblings, 0 replies; 2+ messages in thread
From: Srikar Dronamraju @ 2019-12-26 3:55 UTC (permalink / raw)
To: Guenter Roeck
Cc: Michael Ellerman, Peter Zijlstra, Ingo Molnar, Will Deacon,
Benjamin Herrenschmidt, Paul Mackerras, linux-kernel,
linuxppc-dev, Phil Auld, Waiman Long, Juri Lelli
* Guenter Roeck <linux@roeck-us.net> [2019-12-25 08:06:26]:
> Since commit 656c21d6af5d ("powerpc/shared: Use static key to detect
> shared processor") and 14c73bd344da ("powerpc/vcpu: Assume dedicated
> processors as non-preempt"), powerpc test builds may fail with the
> following build errors.
>
> ./arch/powerpc/include/asm/spinlock.h:39:1: error:
> type defaults to ???int??? in declaration of ???DECLARE_STATIC_KEY_FALSE???
> ./arch/powerpc/include/asm/spinlock.h: In function ???vcpu_is_preempted???:
> ./arch/powerpc/include/asm/spinlock.h:44:7: error:
> implicit declaration of function ???static_branch_unlikely???
> ./arch/powerpc/include/asm/spinlock.h:44:31: error:
> ???shared_processor??? undeclared
>
> The offending commits use static_branch_unlikely and shared_processor
> without adding the include file declaring it.
Thanks for reporting but same fix was already posted
http://lkml.kernel.org/r/20191223133147.129983-1-Jason@zx2c4.com
--
Thanks and Regards
Srikar Dronamraju
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-26 3:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-25 16:06 [PATCH] powerpc/shared: Fix build problem Guenter Roeck
2019-12-26 3:55 ` Srikar Dronamraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).