From: Gen Zhang <blackgod016574@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: nsekhar@ti.com, bgolaszewski@baylibre.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] board-dm644x-evm: fix 2 missing-check bugs in evm_led_setup()
Date: Sat, 28 Dec 2019 21:19:30 +0800 [thread overview]
Message-ID: <20191228131930.GA7214@zhanggen-UX430UQ.lan> (raw)
In-Reply-To: <20191227160142.GW25745@shell.armlinux.org.uk>
On Fri, Dec 27, 2019 at 04:01:42PM +0000, Russell King - ARM Linux admin wrote:
> On Fri, Dec 27, 2019 at 10:39:21AM +0800, Gen Zhang wrote:
> > In evm_led_setup(), the allocation result of platform_device_alloc() and
> > platform_device_add_data() should be checked.
> >
> > Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> > ---
> > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> > index 9d87d4e..9cd2785 100644
> > --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> > @@ -352,15 +352,20 @@ evm_led_setup(struct i2c_client *client, int gpio, unsigned ngpio, void *c)
> > * device unregistration ...
> > */
> > evm_led_dev = platform_device_alloc("leds-gpio", 0);
> > - platform_device_add_data(evm_led_dev,
> > + if (!evm_led_dev)
> > + return -ENOMEM;
> > + status = platform_device_add_data(evm_led_dev,
> > &evm_led_data, sizeof evm_led_data);
> > + if (status)
> > + goto err;
> >
> > evm_led_dev->dev.parent = &client->dev;
> > status = platform_device_add(evm_led_dev);
> > - if (status < 0) {
> > - platform_device_put(evm_led_dev);
> > - evm_led_dev = NULL;
> > - }
> > + if (status)
> > + goto err;
> > +err:
> > + platform_device_put(evm_led_dev);
> > + evm_led_dev = NULL;
>
> Please look again at the above change very closely. You will want to
> send an updated patch.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
Thanks for your reply. You mean the if (state < 0 ) to if (state) or
anything else? Please point out directly.
Best,
Gen
next prev parent reply other threads:[~2019-12-28 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 2:39 [PATCH] board-dm644x-evm: fix 2 missing-check bugs in evm_led_setup() Gen Zhang
2019-12-27 16:01 ` Russell King - ARM Linux admin
2019-12-28 13:19 ` Gen Zhang [this message]
2019-12-28 13:48 ` Russell King - ARM Linux admin
2019-12-28 15:40 ` Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191228131930.GA7214@zhanggen-UX430UQ.lan \
--to=blackgod016574@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).