From: Gen Zhang <blackgod016574@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: bgolaszewski@baylibre.com, nsekhar@ti.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] board-dm644x-evm: fix 2 missing-check bugs in evm_led_setup()
Date: Sat, 28 Dec 2019 23:40:39 +0800 [thread overview]
Message-ID: <20191228154039.GA8713@zhanggen-UX430UQ.lan> (raw)
In-Reply-To: <20191228134824.GX25745@shell.armlinux.org.uk>
On Sat, Dec 28, 2019 at 01:48:24PM +0000, Russell King - ARM Linux admin wrote:
> This is the old everything-successful path through the code:
>
> platform_device_alloc()
> platform_device_add_data()
> platform_device_add()
> evm_led_dev is set to the device
>
> This is the new everything-successful path through the code:
>
> platform_device_alloc()
> platform_device_add_data()
> platform_device_add()
> platform_device_put()
> evm_led_dev = NULL
Thanks for your reply. Adding a return may handle this.
successful path:
platform_device_alloc()
platform_device_add_data()
platform_device_add()
return status
error path:
platform_device_put()
evm_led_dev = NULL
return status
correct?
>
> And, specifically, the code sequence (I quote from your patch):
>
> if (status)
> goto err;
> err:
>
> is very stupid; it might as well not exist at all.
Well, you have to admit that the result of platform_device_alloc(),
platform_device_add_data() and platform_device_add() should be checked,
and error should be handled.
e.g., there are 124 call sites of platform_device_add_data() in Linux. Only 24
are not checked, and most of them are in arm subsystem.
Look forward to deeper discussion of this problem.
Best,
Gen
>
> Since other code references evm_led_dev, one can assume that we do
> not want it to be NULL for the success path. So, taking all this
> together, your patch is very very wrong, and I also find it very
> worrying too.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
prev parent reply other threads:[~2019-12-28 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 2:39 [PATCH] board-dm644x-evm: fix 2 missing-check bugs in evm_led_setup() Gen Zhang
2019-12-27 16:01 ` Russell King - ARM Linux admin
2019-12-28 13:19 ` Gen Zhang
2019-12-28 13:48 ` Russell King - ARM Linux admin
2019-12-28 15:40 ` Gen Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191228154039.GA8713@zhanggen-UX430UQ.lan \
--to=blackgod016574@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).