[PATCH V2] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

[PATCH V2] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

[yu kuai]

kfree() was called for the same variable twice within an if branch.

Fix it by deleting a duplicate function call.

Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
 drivers/gpu/drm/v3d/v3d_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 549dde83408b..37515e47b47e 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -568,7 +568,6 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
 		ret = v3d_job_init(v3d, file_priv, &bin->base,
 				   v3d_job_free, args->in_sync_bcl);
 		if (ret) {
-			kfree(bin);
 			v3d_job_put(&render->base);
 			kfree(bin);
 			return ret;
-- 
2.17.2

Re: [PATCH V2] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

[Markus Elfring]

> kfree() was called for the same variable twice within an if branch.

I wonder still how this software situation happened.


Now I imagine that it could be more logical to delete the second of
this function call if you would like to look at the history of previous
two patches once more.


How do you think about to add another jump target for a bit of common
exception handling?

Regards,
Markus