* [PATCH] panel: simple: Add Ivo M133NWF4 R0
@ 2019-12-29 6:06 Bjorn Andersson
2020-01-02 8:55 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2019-12-29 6:06 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel, Rob Clark
The InfoVision Optoelectronics M133NWF4 R0 panel is a 13.3" 1920x1080
eDP panel, add support for it in panel-simple.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/gpu/drm/panel/panel-simple.c | 31 ++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ba3f85f36c2f..d7ae0ede2b6e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1806,6 +1806,34 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};
+static const struct drm_display_mode ivo_m133nwf4_r0_mode = {
+ .clock = 138778,
+ .hdisplay = 1920,
+ .hsync_start = 1920 + 24,
+ .hsync_end = 1920 + 24 + 48,
+ .htotal = 1920 + 24 + 48 + 88,
+ .vdisplay = 1080,
+ .vsync_start = 1080 + 3,
+ .vsync_end = 1080 + 3 + 12,
+ .vtotal = 1080 + 3 + 12 + 17,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc ivo_m133nwf4_r0 = {
+ .modes = &ivo_m133nwf4_r0_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 294,
+ .height = 165,
+ },
+ .delay = {
+ .hpd_absent_delay = 200,
+ .unprepare = 500,
+ },
+};
+
static const struct display_timing koe_tx14d24vm1bpa_timing = {
.pixelclock = { 5580000, 5850000, 6200000 },
.hactive = { 320, 320, 320 },
@@ -3266,6 +3294,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
+ }, {
+ .compatible = "ivo,m133nwf4-r0",
+ .data = &ivo_m133nwf4_r0,
}, {
.compatible = "koe,tx14d24vm1bpa",
.data = &koe_tx14d24vm1bpa,
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] panel: simple: Add Ivo M133NWF4 R0
2019-12-29 6:06 [PATCH] panel: simple: Add Ivo M133NWF4 R0 Bjorn Andersson
@ 2020-01-02 8:55 ` Sam Ravnborg
2020-01-03 5:34 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2020-01-02 8:55 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, Rob Clark
Hi Bjorn.
On Sat, Dec 28, 2019 at 10:06:58PM -0800, Bjorn Andersson wrote:
> The InfoVision Optoelectronics M133NWF4 R0 panel is a 13.3" 1920x1080
> eDP panel, add support for it in panel-simple.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 31 ++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index ba3f85f36c2f..d7ae0ede2b6e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1806,6 +1806,34 @@ static const struct panel_desc innolux_zj070na_01p = {
> },
> };
>
> +static const struct drm_display_mode ivo_m133nwf4_r0_mode = {
> + .clock = 138778,
> + .hdisplay = 1920,
> + .hsync_start = 1920 + 24,
> + .hsync_end = 1920 + 24 + 48,
> + .htotal = 1920 + 24 + 48 + 88,
> + .vdisplay = 1080,
> + .vsync_start = 1080 + 3,
> + .vsync_end = 1080 + 3 + 12,
> + .vtotal = 1080 + 3 + 12 + 17,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc ivo_m133nwf4_r0 = {
> + .modes = &ivo_m133nwf4_r0_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 294,
> + .height = 165,
> + },
> + .delay = {
> + .hpd_absent_delay = 200,
> + .unprepare = 500,
> + },
> +};
For new bindings - at least add connector_type.
And consider bus_format and bus_flags too.
> +
> static const struct display_timing koe_tx14d24vm1bpa_timing = {
> .pixelclock = { 5580000, 5850000, 6200000 },
> .hactive = { 320, 320, 320 },
> @@ -3266,6 +3294,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "innolux,zj070na-01p",
> .data = &innolux_zj070na_01p,
> + }, {
> + .compatible = "ivo,m133nwf4-r0",
Compatible must be documented in a binding file.
We are discussing a new binding format where it is simple to add
a new panel. But no final conclusion yet.
The comments above (in panel_desc and here) also apply for the
other patch you sent.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] panel: simple: Add Ivo M133NWF4 R0
2020-01-02 8:55 ` Sam Ravnborg
@ 2020-01-03 5:34 ` Bjorn Andersson
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-01-03 5:34 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, Rob Clark
On Thu 02 Jan 00:55 PST 2020, Sam Ravnborg wrote:
> Hi Bjorn.
>
> On Sat, Dec 28, 2019 at 10:06:58PM -0800, Bjorn Andersson wrote:
> > The InfoVision Optoelectronics M133NWF4 R0 panel is a 13.3" 1920x1080
> > eDP panel, add support for it in panel-simple.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 31 ++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index ba3f85f36c2f..d7ae0ede2b6e 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1806,6 +1806,34 @@ static const struct panel_desc innolux_zj070na_01p = {
> > },
> > };
> >
> > +static const struct drm_display_mode ivo_m133nwf4_r0_mode = {
> > + .clock = 138778,
> > + .hdisplay = 1920,
> > + .hsync_start = 1920 + 24,
> > + .hsync_end = 1920 + 24 + 48,
> > + .htotal = 1920 + 24 + 48 + 88,
> > + .vdisplay = 1080,
> > + .vsync_start = 1080 + 3,
> > + .vsync_end = 1080 + 3 + 12,
> > + .vtotal = 1080 + 3 + 12 + 17,
> > + .vrefresh = 60,
> > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> > +};
> > +
> > +static const struct panel_desc ivo_m133nwf4_r0 = {
> > + .modes = &ivo_m133nwf4_r0_mode,
> > + .num_modes = 1,
> > + .bpc = 8,
> > + .size = {
> > + .width = 294,
> > + .height = 165,
> > + },
> > + .delay = {
> > + .hpd_absent_delay = 200,
> > + .unprepare = 500,
> > + },
> > +};
>
> For new bindings - at least add connector_type.
> And consider bus_format and bus_flags too.
>
Sure thing, will update the two patches.
>
> > +
> > static const struct display_timing koe_tx14d24vm1bpa_timing = {
> > .pixelclock = { 5580000, 5850000, 6200000 },
> > .hactive = { 320, 320, 320 },
> > @@ -3266,6 +3294,9 @@ static const struct of_device_id platform_of_match[] = {
> > }, {
> > .compatible = "innolux,zj070na-01p",
> > .data = &innolux_zj070na_01p,
> > + }, {
> > + .compatible = "ivo,m133nwf4-r0",
> Compatible must be documented in a binding file.
> We are discussing a new binding format where it is simple to add
> a new panel. But no final conclusion yet.
>
Okay, will spin some DT bindings for these as well.
Thanks,
Bjorn
> The comments above (in panel_desc and here) also apply for the
> other patch you sent.
>
> Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-03 5:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-29 6:06 [PATCH] panel: simple: Add Ivo M133NWF4 R0 Bjorn Andersson
2020-01-02 8:55 ` Sam Ravnborg
2020-01-03 5:34 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).