* [PATCH] drm/omapdrm: use BUG_ON macro for error debugging.
@ 2020-01-02 9:55 Wambui Karuga
2020-01-08 17:35 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Wambui Karuga @ 2020-01-02 9:55 UTC (permalink / raw)
To: tomi.valkeinen, airlied, daniel; +Cc: dri-devel, linux-kernel
Since the if statement only checks for the value of the `id` variable,
it can be replaced by the more concise BUG_ON() macro for error
reporting.
Issue found using coccinelle.
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
index 413dbdd1771e..dbb90f2d2ccd 100644
--- a/drivers/gpu/drm/omapdrm/dss/dispc.c
+++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
@@ -393,8 +393,7 @@ static void dispc_get_reg_field(struct dispc_device *dispc,
enum dispc_feat_reg_field id,
u8 *start, u8 *end)
{
- if (id >= dispc->feat->num_reg_fields)
- BUG();
+ BUG_ON(id >= dispc->feat->num_reg_fields);
*start = dispc->feat->reg_fields[id].start;
*end = dispc->feat->reg_fields[id].end;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/omapdrm: use BUG_ON macro for error debugging.
2020-01-02 9:55 [PATCH] drm/omapdrm: use BUG_ON macro for error debugging Wambui Karuga
@ 2020-01-08 17:35 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2020-01-08 17:35 UTC (permalink / raw)
To: Wambui Karuga; +Cc: tomi.valkeinen, airlied, daniel, dri-devel, linux-kernel
On Thu, Jan 02, 2020 at 12:55:15PM +0300, Wambui Karuga wrote:
> Since the if statement only checks for the value of the `id` variable,
> it can be replaced by the more concise BUG_ON() macro for error
> reporting.
> Issue found using coccinelle.
>
> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Tomi said he's ok with this landing in drm-misc-next on irc, so merged.
Thanks for your patch!
-Daniel
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index 413dbdd1771e..dbb90f2d2ccd 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -393,8 +393,7 @@ static void dispc_get_reg_field(struct dispc_device *dispc,
> enum dispc_feat_reg_field id,
> u8 *start, u8 *end)
> {
> - if (id >= dispc->feat->num_reg_fields)
> - BUG();
> + BUG_ON(id >= dispc->feat->num_reg_fields);
>
> *start = dispc->feat->reg_fields[id].start;
> *end = dispc->feat->reg_fields[id].end;
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-08 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-02 9:55 [PATCH] drm/omapdrm: use BUG_ON macro for error debugging Wambui Karuga
2020-01-08 17:35 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).