From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, sivaa@codeaurora.org,
Andy Gross <agross@kernel.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 3/9] drivers: thermal: tsens: use simpler variables
Date: Thu, 2 Jan 2020 11:18:35 -0800 [thread overview]
Message-ID: <20200102191835.GB988120@minitux> (raw)
In-Reply-To: <09ac47eea963e84bd3eb630897c2b77f3868b90b.1577976221.git.amit.kucheria@linaro.org>
On Thu 02 Jan 06:54 PST 2020, Amit Kucheria wrote:
> We already dereference the sensor and save it into a variable. Use the
> variable directly to make the code easier to read.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/qcom/tsens-common.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index c2df30a08b9e..1cbc5a6e5b4f 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
> tsens_set_interrupt(priv, hw_id, UPPER, disable);
> if (d.up_thresh > temp) {
> dev_dbg(priv->dev, "[%u] %s: re-arm upper\n",
> - priv->sensor[i].hw_id, __func__);
> + hw_id, __func__);
> tsens_set_interrupt(priv, hw_id, UPPER, enable);
> } else {
> trigger = true;
> @@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
> tsens_set_interrupt(priv, hw_id, LOWER, disable);
> if (d.low_thresh < temp) {
> dev_dbg(priv->dev, "[%u] %s: re-arm low\n",
> - priv->sensor[i].hw_id, __func__);
> + hw_id, __func__);
> tsens_set_interrupt(priv, hw_id, LOWER, enable);
> } else {
> trigger = true;
> @@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
> if (trigger) {
> dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n",
> hw_id, __func__, temp);
> - thermal_zone_device_update(priv->sensor[i].tzd,
> + thermal_zone_device_update(s->tzd,
> THERMAL_EVENT_UNSPECIFIED);
> } else {
> dev_dbg(priv->dev, "[%u] %s: no violation: %d\n",
> @@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
> spin_unlock_irqrestore(&priv->ul_lock, flags);
>
> dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n",
> - s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
> + hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
>
> return 0;
> }
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-01-02 19:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 14:54 [PATCH v3 0/9] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 1/9] drivers: thermal: tsens: De-constify struct tsens_features Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 2/9] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-01-02 19:16 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 3/9] drivers: thermal: tsens: use simpler variables Amit Kucheria
2020-01-02 19:18 ` Bjorn Andersson [this message]
2020-01-02 14:54 ` [PATCH v3 4/9] drivers: thermal: tsens: Release device in success path Amit Kucheria
2020-01-02 19:29 ` Bjorn Andersson
2020-01-30 12:49 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 5/9] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-01-02 19:45 ` Bjorn Andersson
2020-01-30 12:07 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 6/9] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-01-02 19:55 ` Bjorn Andersson
2020-01-30 12:12 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 7/9] arm64: dts: sdm845: thermal: Add critical interrupt support Amit Kucheria
2020-01-02 19:58 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 8/9] arm64: dts: msm8996: " Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 9/9] arm64: dts: msm8998: " Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102191835.GB988120@minitux \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).