From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, sivaa@codeaurora.org,
Andy Gross <agross@kernel.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 6/9] drivers: thermal: tsens: Add watchdog support
Date: Thu, 2 Jan 2020 11:55:37 -0800 [thread overview]
Message-ID: <20200102195537.GE988120@minitux> (raw)
In-Reply-To: <a63edff9a3c02a542d36fdd28fe774a5c3bf3b8d.1577976221.git.amit.kucheria@linaro.org>
On Thu 02 Jan 06:54 PST 2020, Amit Kucheria wrote:
[..]
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index 4cf550766cf6..ecbc722eb348 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -377,6 +377,24 @@ irqreturn_t tsens_critical_irq_thread(int irq, void *data)
> struct tsens_irq_data d;
> unsigned long flags;
> int temp, ret, i;
> + u32 wdog_status, wdog_count;
> +
> + if (priv->feat->has_watchdog) {
> + /* Watchdog is present only on v2.3+ */
Please omit this comment, you're carrying the motivation for this
decision when you set has_watchdog already.
> + ret = regmap_field_read(priv->rf[WDOG_BARK_STATUS], &wdog_status);
> + if (ret)
> + return ret;
> +
> + /* Clear WDOG interrupt */
> + regmap_field_write(priv->rf[WDOG_BARK_CLEAR], 1);
> + regmap_field_write(priv->rf[WDOG_BARK_CLEAR], 0);
Are you sure you need to zero the clear register?
> +
> + ret = regmap_field_read(priv->rf[WDOG_BARK_COUNT], &wdog_count);
> + if (ret)
> + return ret;
> + if (wdog_count)
> + dev_dbg(priv->dev, "%s: watchdog count: %d\n", __func__, wdog_count);
> + }
>
[..]
> @@ -793,6 +815,22 @@ int __init init_common(struct tsens_priv *priv)
> }
> }
>
> + if (tsens_version(priv) > VER_1_X && ver_minor > 2) {
> + /* Watchdog is present only on v2.3+ */
> + priv->feat->has_watchdog = 1;
> + for (i = WDOG_BARK_STATUS; i <= CC_MON_MASK; i++) {
> + priv->rf[i] = devm_regmap_field_alloc(dev, priv->tm_map,
> + priv->fields[i]);
> + if (IS_ERR(priv->rf[i])) {
> + ret = PTR_ERR(priv->rf[i]);
> + goto err_put_device;
> + }
> + }
> + /* Enable WDOG and disable cycle completion monitoring */
Commit message says you're not enabling it. Should this say "WDOG is
already configured, unmask the bark" or something along those lines?
> + regmap_field_write(priv->rf[WDOG_BARK_MASK], 0);
> + regmap_field_write(priv->rf[CC_MON_MASK], 1);
> + }
> +
> spin_lock_init(&priv->ul_lock);
> tsens_enable_irq(priv);
> tsens_debug_init(op);
Regards,
Bjorn
next prev parent reply other threads:[~2020-01-02 19:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 14:54 [PATCH v3 0/9] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 1/9] drivers: thermal: tsens: De-constify struct tsens_features Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 2/9] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-01-02 19:16 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 3/9] drivers: thermal: tsens: use simpler variables Amit Kucheria
2020-01-02 19:18 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 4/9] drivers: thermal: tsens: Release device in success path Amit Kucheria
2020-01-02 19:29 ` Bjorn Andersson
2020-01-30 12:49 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 5/9] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-01-02 19:45 ` Bjorn Andersson
2020-01-30 12:07 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 6/9] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-01-02 19:55 ` Bjorn Andersson [this message]
2020-01-30 12:12 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 7/9] arm64: dts: sdm845: thermal: Add critical interrupt support Amit Kucheria
2020-01-02 19:58 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 8/9] arm64: dts: msm8996: " Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 9/9] arm64: dts: msm8998: " Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102195537.GE988120@minitux \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).