kernel//trace/fgraph.c:111:35: error: 'MCOUNT_INSN_SIZE' undeclared; did you mean 'UCOUNT_COUNTS'?

* kernel//trace/fgraph.c:111:35: error: 'MCOUNT_INSN_SIZE' undeclared; did you mean 'UCOUNT_COUNTS'?
@ 2020-01-01 18:09 kbuild test robot
  2020-01-03  3:07 ` Steven Rostedt
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2020-01-01 18:09 UTC (permalink / raw)
  To: Alexei Starovoitov; +Cc: kbuild-all, linux-kernel, Steven Rostedt (VMware)

[-- Attachment #1: Type: text/plain, Size: 2605 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   738d2902773e30939a982c8df7a7f94293659810
commit: ff205766dbbee024a4a716638868d98ffb17748a ftrace: Fix function_graph tracer interaction with BPF trampoline
date:   3 weeks ago
config: riscv-randconfig-a001-20200102 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ff205766dbbee024a4a716638868d98ffb17748a
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel//trace/fgraph.c: In function 'function_graph_enter':
>> kernel//trace/fgraph.c:111:35: error: 'MCOUNT_INSN_SIZE' undeclared (first use in this function); did you mean 'UCOUNT_COUNTS'?
         ftrace_find_rec_direct(ret - MCOUNT_INSN_SIZE))
                                      ^~~~~~~~~~~~~~~~
                                      UCOUNT_COUNTS
   kernel//trace/fgraph.c:111:35: note: each undeclared identifier is reported only once for each function it appears in

vim +111 kernel//trace/fgraph.c

    98	
    99	int function_graph_enter(unsigned long ret, unsigned long func,
   100				 unsigned long frame_pointer, unsigned long *retp)
   101	{
   102		struct ftrace_graph_ent trace;
   103	
   104		/*
   105		 * Skip graph tracing if the return location is served by direct trampoline,
   106		 * since call sequence and return addresses is unpredicatable anymore.
   107		 * Ex: BPF trampoline may call original function and may skip frame
   108		 * depending on type of BPF programs attached.
   109		 */
   110		if (ftrace_direct_func_count &&
 > 111		    ftrace_find_rec_direct(ret - MCOUNT_INSN_SIZE))
   112			return -EBUSY;
   113		trace.func = func;
   114		trace.depth = ++current->curr_ret_depth;
   115	
   116		if (ftrace_push_return_trace(ret, func, frame_pointer, retp))
   117			goto out;
   118	
   119		/* Only trace if the calling function expects to */
   120		if (!ftrace_graph_entry(&trace))
   121			goto out_ret;
   122	
   123		return 0;
   124	 out_ret:
   125		current->curr_ret_stack--;
   126	 out:
   127		current->curr_ret_depth--;
   128		return -EBUSY;
   129	}
   130	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24697 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread