* [PATCH] fpga: remove redundant dev_err message
@ 2019-09-10 9:26 Ding Xiang
2020-01-03 4:59 ` Moritz Fischer
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-09-10 9:26 UTC (permalink / raw)
To: mdf, linux-fpga; +Cc: linux-kernel
devm_ioremap_resource already contains error message, so remove
the redundant dev_err message
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/fpga/ts73xx-fpga.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
index 9a17fe9..2888ff0 100644
--- a/drivers/fpga/ts73xx-fpga.c
+++ b/drivers/fpga/ts73xx-fpga.c
@@ -119,10 +119,8 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
priv->io_base = devm_ioremap_resource(kdev, res);
- if (IS_ERR(priv->io_base)) {
- dev_err(kdev, "unable to remap registers\n");
+ if (IS_ERR(priv->io_base))
return PTR_ERR(priv->io_base);
- }
mgr = devm_fpga_mgr_create(kdev, "TS-73xx FPGA Manager",
&ts73xx_fpga_ops, priv);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fpga: remove redundant dev_err message
2019-09-10 9:26 [PATCH] fpga: remove redundant dev_err message Ding Xiang
@ 2020-01-03 4:59 ` Moritz Fischer
0 siblings, 0 replies; 2+ messages in thread
From: Moritz Fischer @ 2020-01-03 4:59 UTC (permalink / raw)
To: Ding Xiang; +Cc: mdf, linux-fpga, linux-kernel
On Tue, Sep 10, 2019 at 05:26:56PM +0800, Ding Xiang wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/fpga/ts73xx-fpga.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
> index 9a17fe9..2888ff0 100644
> --- a/drivers/fpga/ts73xx-fpga.c
> +++ b/drivers/fpga/ts73xx-fpga.c
> @@ -119,10 +119,8 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> priv->io_base = devm_ioremap_resource(kdev, res);
> - if (IS_ERR(priv->io_base)) {
> - dev_err(kdev, "unable to remap registers\n");
> + if (IS_ERR(priv->io_base))
> return PTR_ERR(priv->io_base);
> - }
>
> mgr = devm_fpga_mgr_create(kdev, "TS-73xx FPGA Manager",
> &ts73xx_fpga_ops, priv);
> --
> 1.9.1
>
>
>
Applied to for-next.
Thanks,
Moritz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-03 4:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 9:26 [PATCH] fpga: remove redundant dev_err message Ding Xiang
2020-01-03 4:59 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).