* [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings
@ 2020-01-03 18:30 Rob Clark
2020-01-03 18:30 ` [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel Rob Clark
2020-01-03 19:35 ` [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings Sam Ravnborg
0 siblings, 2 replies; 7+ messages in thread
From: Rob Clark @ 2020-01-03 18:30 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-msm, Douglas Anderson, Rob Clark, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
.../bindings/display/panel/auo,b116xa01.yaml | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml b/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
new file mode 100644
index 000000000000..6cb8ed9b2c0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/auo,b116xa01.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AUO B116XAK01 eDP TFT LCD Panel
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ enum:
+ - auo,b116xa01
+ port: true
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ panel {
+ compatible = "auo,b116xa01";
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&edp_out>;
+ };
+ };
+ };
--
2.24.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel
2020-01-03 18:30 [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings Rob Clark
@ 2020-01-03 18:30 ` Rob Clark
2020-01-03 19:31 ` Sam Ravnborg
2020-01-03 19:35 ` [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings Sam Ravnborg
1 sibling, 1 reply; 7+ messages in thread
From: Rob Clark @ 2020-01-03 18:30 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-msm, Douglas Anderson, Rob Clark, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, open list
From: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5d487686d25c..895a25cfc54f 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -680,6 +680,35 @@ static const struct panel_desc auo_b116xw03 = {
},
};
+static const struct drm_display_mode auo_b116xak01_mode = {
+ .clock = 69300,
+ .hdisplay = 1366,
+ .hsync_start = 1366 + 48,
+ .hsync_end = 1366 + 48 + 32,
+ .htotal = 1366 + 48 + 32 + 10,
+ .vdisplay = 768,
+ .vsync_start = 768 + 4,
+ .vsync_end = 768 + 4 + 6,
+ .vtotal = 768 + 4 + 6 + 15,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc auo_b116xak01 = {
+ .modes = &auo_b116xak01_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 256,
+ .height = 144,
+ },
+ .delay = {
+ .hpd_absent_delay = 200,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+ .connector_type = DRM_MODE_CONNECTOR_eDP,
+};
+
static const struct drm_display_mode auo_b133xtn01_mode = {
.clock = 69500,
.hdisplay = 1366,
@@ -3125,6 +3154,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "auo,b133htn01",
.data = &auo_b133htn01,
+ }, {
+ .compatible = "auo,b116xa01",
+ .data = &auo_b116xak01,
}, {
.compatible = "auo,b133xtn01",
.data = &auo_b133xtn01,
--
2.24.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel
2020-01-03 18:30 ` [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel Rob Clark
@ 2020-01-03 19:31 ` Sam Ravnborg
2020-01-03 19:47 ` Rob Clark
0 siblings, 1 reply; 7+ messages in thread
From: Sam Ravnborg @ 2020-01-03 19:31 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, Douglas Anderson, Rob Clark,
Thierry Reding, David Airlie, Daniel Vetter, open list
Hi Rob.
On Fri, Jan 03, 2020 at 10:30:24AM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5d487686d25c..895a25cfc54f 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -680,6 +680,35 @@ static const struct panel_desc auo_b116xw03 = {
> },
> };
>
> +static const struct drm_display_mode auo_b116xak01_mode = {
> + .clock = 69300,
> + .hdisplay = 1366,
> + .hsync_start = 1366 + 48,
> + .hsync_end = 1366 + 48 + 32,
> + .htotal = 1366 + 48 + 32 + 10,
> + .vdisplay = 768,
> + .vsync_start = 768 + 4,
> + .vsync_end = 768 + 4 + 6,
> + .vtotal = 768 + 4 + 6 + 15,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc auo_b116xak01 = {
> + .modes = &auo_b116xak01_mode,
> + .num_modes = 1,
> + .bpc = 6,
> + .size = {
> + .width = 256,
> + .height = 144,
> + },
> + .delay = {
> + .hpd_absent_delay = 200,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
> +};
Entries in alphabetical order - check.
.connector_type specified - check.
.flags and .bus_format specified - check.
.bus_flags not specified but optional - OK.
> +
> static const struct drm_display_mode auo_b133xtn01_mode = {
> .clock = 69500,
> .hdisplay = 1366,
> @@ -3125,6 +3154,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "auo,b133htn01",
> .data = &auo_b133htn01,
> + }, {
> + .compatible = "auo,b116xa01",
> + .data = &auo_b116xak01,
This entry most also be in alphabetical order.
> }, {
> .compatible = "auo,b133xtn01",
> .data = &auo_b133xtn01,
Please fix and resend.
I am in general holding back on patches to panel-simple.
I hope we can reach a decision for the way forward with the bindings
files sometimes next week.
Sam
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings
2020-01-03 18:30 [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings Rob Clark
2020-01-03 18:30 ` [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel Rob Clark
@ 2020-01-03 19:35 ` Sam Ravnborg
1 sibling, 0 replies; 7+ messages in thread
From: Sam Ravnborg @ 2020-01-03 19:35 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, Douglas Anderson, Rob Clark,
Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Rob.
On Fri, Jan 03, 2020 at 10:30:23AM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> .../bindings/display/panel/auo,b116xa01.yaml | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml b/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
> new file mode 100644
> index 000000000000..6cb8ed9b2c0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/auo,b116xa01.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AUO B116XAK01 eDP TFT LCD Panel
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - auo,b116xa01
> + port: true
Add an empty line before listing the other properties.
> +
> +required:
> + - compatible
The panel needs power - so power-supply is required too.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + panel {
> + compatible = "auo,b116xa01";
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&edp_out>;
> + };
> + };
> + };
For simple panels the example is more or less noise.
We are discusing to move all binding info to a few files for the simple
(dumb) panels.
This is a candidate for this as well.
But there is not yet a conclusion.
Sam
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel
2020-01-03 19:31 ` Sam Ravnborg
@ 2020-01-03 19:47 ` Rob Clark
2020-01-03 19:54 ` Sam Ravnborg
0 siblings, 1 reply; 7+ messages in thread
From: Rob Clark @ 2020-01-03 19:47 UTC (permalink / raw)
To: Sam Ravnborg
Cc: dri-devel, linux-arm-msm, Douglas Anderson, Rob Clark,
Thierry Reding, David Airlie, Daniel Vetter, open list
On Fri, Jan 3, 2020 at 11:31 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Rob.
>
> On Fri, Jan 03, 2020 at 10:30:24AM -0800, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 5d487686d25c..895a25cfc54f 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -680,6 +680,35 @@ static const struct panel_desc auo_b116xw03 = {
> > },
> > };
> >
> > +static const struct drm_display_mode auo_b116xak01_mode = {
> > + .clock = 69300,
> > + .hdisplay = 1366,
> > + .hsync_start = 1366 + 48,
> > + .hsync_end = 1366 + 48 + 32,
> > + .htotal = 1366 + 48 + 32 + 10,
> > + .vdisplay = 768,
> > + .vsync_start = 768 + 4,
> > + .vsync_end = 768 + 4 + 6,
> > + .vtotal = 768 + 4 + 6 + 15,
> > + .vrefresh = 60,
> > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> > +};
> > +
> > +static const struct panel_desc auo_b116xak01 = {
> > + .modes = &auo_b116xak01_mode,
> > + .num_modes = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 256,
> > + .height = 144,
> > + },
> > + .delay = {
> > + .hpd_absent_delay = 200,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .connector_type = DRM_MODE_CONNECTOR_eDP,
> > +};
> Entries in alphabetical order - check.
> .connector_type specified - check.
> .flags and .bus_format specified - check.
> .bus_flags not specified but optional - OK.
>
> > +
> > static const struct drm_display_mode auo_b133xtn01_mode = {
> > .clock = 69500,
> > .hdisplay = 1366,
> > @@ -3125,6 +3154,9 @@ static const struct of_device_id platform_of_match[] = {
> > }, {
> > .compatible = "auo,b133htn01",
> > .data = &auo_b133htn01,
> > + }, {
> > + .compatible = "auo,b116xa01",
> > + .data = &auo_b116xak01,
> This entry most also be in alphabetical order.
>
> > }, {
> > .compatible = "auo,b133xtn01",
> > .data = &auo_b133xtn01,
>
> Please fix and resend.
>
> I am in general holding back on patches to panel-simple.
> I hope we can reach a decision for the way forward with the bindings
> files sometimes next week.
I've fixed the sort-order and the couple things you've pointed out in
the bindings. Not sure if you want me to resend immediately or
hang-tight until the bindings discussion is resolved?
BR,
-R
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel
2020-01-03 19:47 ` Rob Clark
@ 2020-01-03 19:54 ` Sam Ravnborg
2020-01-03 19:58 ` Rob Clark
0 siblings, 1 reply; 7+ messages in thread
From: Sam Ravnborg @ 2020-01-03 19:54 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, Douglas Anderson, Rob Clark,
Thierry Reding, David Airlie, Daniel Vetter, open list
Hi Rob.
> > Please fix and resend.
> >
> > I am in general holding back on patches to panel-simple.
> > I hope we can reach a decision for the way forward with the bindings
> > files sometimes next week.
>
> I've fixed the sort-order and the couple things you've pointed out in
> the bindings. Not sure if you want me to resend immediately or
> hang-tight until the bindings discussion is resolved?
Could we give it until Wednesday - if we do not resolve the
binding discussion I will process panel patches in the weekend or maybe
a day before.
Sam
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel
2020-01-03 19:54 ` Sam Ravnborg
@ 2020-01-03 19:58 ` Rob Clark
0 siblings, 0 replies; 7+ messages in thread
From: Rob Clark @ 2020-01-03 19:58 UTC (permalink / raw)
To: Sam Ravnborg
Cc: dri-devel, linux-arm-msm, Douglas Anderson, Rob Clark,
Thierry Reding, David Airlie, Daniel Vetter, open list
On Fri, Jan 3, 2020 at 11:54 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Rob.
>
> > > Please fix and resend.
> > >
> > > I am in general holding back on patches to panel-simple.
> > > I hope we can reach a decision for the way forward with the bindings
> > > files sometimes next week.
> >
> > I've fixed the sort-order and the couple things you've pointed out in
> > the bindings. Not sure if you want me to resend immediately or
> > hang-tight until the bindings discussion is resolved?
> Could we give it until Wednesday - if we do not resolve the
> binding discussion I will process panel patches in the weekend or maybe
> a day before.
sounds good
BR,
-R
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-03 19:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03 18:30 [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings Rob Clark
2020-01-03 18:30 ` [PATCH 2/2] drm/panel: Add support for AUO B116XAK01 panel Rob Clark
2020-01-03 19:31 ` Sam Ravnborg
2020-01-03 19:47 ` Rob Clark
2020-01-03 19:54 ` Sam Ravnborg
2020-01-03 19:58 ` Rob Clark
2020-01-03 19:35 ` [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).