* [PATCH 1/2] ide: ht6560b: Fix cast to pointer from integer of different size
@ 2020-01-04 14:33 Krzysztof Kozlowski
2020-01-04 14:33 ` [PATCH 2/2] ide: qd65xx: " Krzysztof Kozlowski
2020-01-20 13:40 ` [PATCH 1/2] ide: ht6560b: " David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-04 14:33 UTC (permalink / raw)
To: David S. Miller, linux-ide, linux-kernel; +Cc: Krzysztof Kozlowski
Integer passed as pointer to drvdata should be cast to unsigned long to
avoid warning (compile testing on alpha architecture):
drivers/ide/ht6560b.c: In function ‘ht6560b_init_dev’:
drivers/ide/ht6560b.c:318:27: warning:
cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Only compile tested
---
drivers/ide/ht6560b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/ht6560b.c b/drivers/ide/ht6560b.c
index 0dae65ac7d6d..743bc3693ac8 100644
--- a/drivers/ide/ht6560b.c
+++ b/drivers/ide/ht6560b.c
@@ -310,7 +310,7 @@ static void __init ht6560b_init_dev(ide_drive_t *drive)
{
ide_hwif_t *hwif = drive->hwif;
/* Setting default configurations for drives. */
- int t = (HT_CONFIG_DEFAULT << 8) | HT_TIMING_DEFAULT;
+ unsigned long t = (HT_CONFIG_DEFAULT << 8) | HT_TIMING_DEFAULT;
if (hwif->channel)
t |= (HT_SECONDARY_IF << 8);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ide: qd65xx: Fix cast to pointer from integer of different size
2020-01-04 14:33 [PATCH 1/2] ide: ht6560b: Fix cast to pointer from integer of different size Krzysztof Kozlowski
@ 2020-01-04 14:33 ` Krzysztof Kozlowski
2020-01-20 13:40 ` David Miller
2020-01-20 13:40 ` [PATCH 1/2] ide: ht6560b: " David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-04 14:33 UTC (permalink / raw)
To: David S. Miller, linux-ide, linux-kernel; +Cc: Krzysztof Kozlowski
Integer passed as pointer to drvdata should be cast to unsigned long to
avoid warning (compile testing on alpha architecture):
drivers/ide/qd65xx.c: In function ‘qd6580_init_dev’:
drivers/ide/qd65xx.c:312:27: warning:
cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Only compile tested
---
drivers/ide/qd65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/qd65xx.c b/drivers/ide/qd65xx.c
index 6ce318ebd0cc..ab79b6289464 100644
--- a/drivers/ide/qd65xx.c
+++ b/drivers/ide/qd65xx.c
@@ -299,7 +299,7 @@ static void __init qd6500_init_dev(ide_drive_t *drive)
static void __init qd6580_init_dev(ide_drive_t *drive)
{
ide_hwif_t *hwif = drive->hwif;
- u16 t1, t2;
+ unsigned long t1, t2;
u8 base = (hwif->config_data & 0xff00) >> 8;
u8 config = QD_CONFIG(hwif);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ide: ht6560b: Fix cast to pointer from integer of different size
2020-01-04 14:33 [PATCH 1/2] ide: ht6560b: Fix cast to pointer from integer of different size Krzysztof Kozlowski
2020-01-04 14:33 ` [PATCH 2/2] ide: qd65xx: " Krzysztof Kozlowski
@ 2020-01-20 13:40 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-01-20 13:40 UTC (permalink / raw)
To: krzk; +Cc: linux-ide, linux-kernel
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Sat, 4 Jan 2020 15:33:47 +0100
> Integer passed as pointer to drvdata should be cast to unsigned long to
> avoid warning (compile testing on alpha architecture):
>
> drivers/ide/ht6560b.c: In function ‘ht6560b_init_dev’:
> drivers/ide/ht6560b.c:318:27: warning:
> cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ide: qd65xx: Fix cast to pointer from integer of different size
2020-01-04 14:33 ` [PATCH 2/2] ide: qd65xx: " Krzysztof Kozlowski
@ 2020-01-20 13:40 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-01-20 13:40 UTC (permalink / raw)
To: krzk; +Cc: linux-ide, linux-kernel
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Sat, 4 Jan 2020 15:33:48 +0100
> Integer passed as pointer to drvdata should be cast to unsigned long to
> avoid warning (compile testing on alpha architecture):
>
> drivers/ide/qd65xx.c: In function ‘qd6580_init_dev’:
> drivers/ide/qd65xx.c:312:27: warning:
> cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-20 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-04 14:33 [PATCH 1/2] ide: ht6560b: Fix cast to pointer from integer of different size Krzysztof Kozlowski
2020-01-04 14:33 ` [PATCH 2/2] ide: qd65xx: " Krzysztof Kozlowski
2020-01-20 13:40 ` David Miller
2020-01-20 13:40 ` [PATCH 1/2] ide: ht6560b: " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).