* [PATCH] arm64: dts: allwinner: a64: pinebook: Fix lid wakeup
@ 2020-01-05 2:11 Samuel Holland
2020-01-06 8:53 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2020-01-05 2:11 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard
Cc: linux-arm-kernel, linux-kernel, linux-sunxi, Samuel Holland
By default, gpio-keys configures the pin to trigger wakeup IRQs on
either edge. The lid switch should only trigger wakeup when opening the
lid, not when closing it.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
index 78c82a665c84..836ae51e5c2a 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
@@ -10,6 +10,7 @@
#include "sun50i-a64.dtsi"
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/gpio-keys.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/pwm/pwm.h>
@@ -60,6 +61,7 @@
linux,code = <SW_LID>;
linux,can-disable;
wakeup-source;
+ wakeup-event-action = <EV_ACT_DEASSERTED>;
};
};
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: pinebook: Fix lid wakeup
2020-01-05 2:11 [PATCH] arm64: dts: allwinner: a64: pinebook: Fix lid wakeup Samuel Holland
@ 2020-01-06 8:53 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-01-06 8:53 UTC (permalink / raw)
To: Samuel Holland; +Cc: Chen-Yu Tsai, linux-arm-kernel, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
On Sat, Jan 04, 2020 at 08:11:37PM -0600, Samuel Holland wrote:
> By default, gpio-keys configures the pin to trigger wakeup IRQs on
> either edge. The lid switch should only trigger wakeup when opening the
> lid, not when closing it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Applied, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-06 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-05 2:11 [PATCH] arm64: dts: allwinner: a64: pinebook: Fix lid wakeup Samuel Holland
2020-01-06 8:53 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).