* [PATCH v2] siox: Use the correct style for SPDX License Identifier
@ 2020-01-01 13:14 Nishad Kamdar
2020-01-07 6:32 ` Thorsten Scherer
0 siblings, 1 reply; 5+ messages in thread
From: Nishad Kamdar @ 2020-01-01 13:14 UTC (permalink / raw)
To: Thorsten Scherer, Uwe Kleine-König, Pengutronix Kernel Team,
Greg Kroah-Hartman, Joe Perches
Cc: linux-kernel
This patch corrects the SPDX License Identifier style in
header file related to Eckelmann SIOX driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Changes in v2:
- Correct the spelling of the word Eckelmann.
---
drivers/siox/siox.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/siox/siox.h b/drivers/siox/siox.h
index c674bf6fb119..f08b43b713c5 100644
--- a/drivers/siox/siox.h
+++ b/drivers/siox/siox.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) 2015-2017 Pengutronix, Uwe Kleine-König <kernel@pengutronix.de>
*/
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier
2020-01-01 13:14 [PATCH v2] siox: Use the correct style for SPDX License Identifier Nishad Kamdar
@ 2020-01-07 6:32 ` Thorsten Scherer
2020-01-07 7:32 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Thorsten Scherer @ 2020-01-07 6:32 UTC (permalink / raw)
To: Nishad Kamdar
Cc: Uwe Kleine-König, Pengutronix Kernel Team,
Greg Kroah-Hartman, Joe Perches, linux-kernel
On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> This patch corrects the SPDX License Identifier style in
> header file related to Eckelmann SIOX driver.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Thorsten Scherer <thorsten.scherer@eckelmann.de>
> ---
> Changes in v2:
> - Correct the spelling of the word Eckelmann.
> ---
> drivers/siox/siox.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/siox/siox.h b/drivers/siox/siox.h
> index c674bf6fb119..f08b43b713c5 100644
> --- a/drivers/siox/siox.h
> +++ b/drivers/siox/siox.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) 2015-2017 Pengutronix, Uwe Kleine-König <kernel@pengutronix.de>
> */
> --
> 2.17.1
>
Kind regards
Thorsten
--
Thorsten Scherer | Eckelmann AG | www.eckelmann.de |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier
2020-01-07 6:32 ` Thorsten Scherer
@ 2020-01-07 7:32 ` Uwe Kleine-König
2020-01-14 20:47 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2020-01-07 7:32 UTC (permalink / raw)
To: Thorsten Scherer, Nishad Kamdar, Greg Kroah-Hartman
Cc: Pengutronix Kernel Team, Joe Perches, linux-kernel
Hello,
On Tue, Jan 07, 2020 at 07:32:50AM +0100, Thorsten Scherer wrote:
> On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> > This patch corrects the SPDX License Identifier style in
> > header file related to Eckelmann SIOX driver.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Acked-by: Thorsten Scherer <thorsten.scherer@eckelmann.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Greg, do you care for application of this patch?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier
2020-01-07 7:32 ` Uwe Kleine-König
@ 2020-01-14 20:47 ` Greg Kroah-Hartman
2020-01-14 20:49 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-14 20:47 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Thorsten Scherer, Nishad Kamdar, Pengutronix Kernel Team,
Joe Perches, linux-kernel
On Tue, Jan 07, 2020 at 08:32:04AM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Jan 07, 2020 at 07:32:50AM +0100, Thorsten Scherer wrote:
> > On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> > > This patch corrects the SPDX License Identifier style in
> > > header file related to Eckelmann SIOX driver.
> > > For C header files Documentation/process/license-rules.rst
> > > mandates C-like comments (opposed to C source files where
> > > C++ style should be used).
> > >
> > > Changes made by using a script provided by Joe Perches here:
> > > https://lkml.org/lkml/2019/2/7/46.
> > >
> > > Suggested-by: Joe Perches <joe@perches.com>
> > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > Acked-by: Thorsten Scherer <thorsten.scherer@eckelmann.de>
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Ah, this is why I had 2 acks, you acked it twice :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] siox: Use the correct style for SPDX License Identifier
2020-01-14 20:47 ` Greg Kroah-Hartman
@ 2020-01-14 20:49 ` Uwe Kleine-König
0 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2020-01-14 20:49 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thorsten Scherer, Nishad Kamdar, Pengutronix Kernel Team,
Joe Perches, linux-kernel
On Tue, Jan 14, 2020 at 09:47:34PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 07, 2020 at 08:32:04AM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Tue, Jan 07, 2020 at 07:32:50AM +0100, Thorsten Scherer wrote:
> > > On Wed, Jan 01, 2020 at 06:44:23PM +0530, Nishad Kamdar wrote:
> > > > This patch corrects the SPDX License Identifier style in
> > > > header file related to Eckelmann SIOX driver.
> > > > For C header files Documentation/process/license-rules.rst
> > > > mandates C-like comments (opposed to C source files where
> > > > C++ style should be used).
> > > >
> > > > Changes made by using a script provided by Joe Perches here:
> > > > https://lkml.org/lkml/2019/2/7/46.
> > > >
> > > > Suggested-by: Joe Perches <joe@perches.com>
> > > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >
> > > Acked-by: Thorsten Scherer <thorsten.scherer@eckelmann.de>
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Ah, this is why I had 2 acks, you acked it twice :)
Ah, didn't even notice that v2 came with my ack already.
..ooOO(Acked-intensively-by: ...)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-14 20:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-01 13:14 [PATCH v2] siox: Use the correct style for SPDX License Identifier Nishad Kamdar
2020-01-07 6:32 ` Thorsten Scherer
2020-01-07 7:32 ` Uwe Kleine-König
2020-01-14 20:47 ` Greg Kroah-Hartman
2020-01-14 20:49 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).