* [PATCH -next] drm/i915: Add missing include file <linux/math64.h>
@ 2020-01-07 13:50 YueHaibing
2020-01-07 13:53 ` Chris Wilson
2020-01-07 14:02 ` Chris Wilson
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-01-07 13:50 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel,
ville.syrjala, chris, tvrtko.ursulin, yuehaibing, matthew.auld
Cc: intel-gfx, dri-devel, linux-kernel
Fix build error:
./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state:
./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error:
implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration]
return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro));
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/i915/selftests/i915_random.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/selftests/i915_random.h b/drivers/gpu/drm/i915/selftests/i915_random.h
index 35cc69a..f650cfb 100644
--- a/drivers/gpu/drm/i915/selftests/i915_random.h
+++ b/drivers/gpu/drm/i915/selftests/i915_random.h
@@ -26,6 +26,7 @@
#define __I915_SELFTESTS_RANDOM_H__
#include <linux/random.h>
+#include <linux/math64.h>
#include "../i915_selftest.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/i915: Add missing include file <linux/math64.h>
2020-01-07 13:50 [PATCH -next] drm/i915: Add missing include file <linux/math64.h> YueHaibing
@ 2020-01-07 13:53 ` Chris Wilson
2020-01-07 14:02 ` Chris Wilson
1 sibling, 0 replies; 3+ messages in thread
From: Chris Wilson @ 2020-01-07 13:53 UTC (permalink / raw)
To: airlied, daniel, jani.nikula, joonas.lahtinen, matthew.auld,
rodrigo.vivi, tvrtko.ursulin, ville.syrjala, yuehaibing
Cc: intel-gfx, dri-devel, linux-kernel
Quoting YueHaibing (2020-01-07 13:50:14)
> Fix build error:
> ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state:
> ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error:
> implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration]
> return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro));
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result")
While technically true, that doesn't explain why it only just started
appearing on -next.
-Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/i915: Add missing include file <linux/math64.h>
2020-01-07 13:50 [PATCH -next] drm/i915: Add missing include file <linux/math64.h> YueHaibing
2020-01-07 13:53 ` Chris Wilson
@ 2020-01-07 14:02 ` Chris Wilson
1 sibling, 0 replies; 3+ messages in thread
From: Chris Wilson @ 2020-01-07 14:02 UTC (permalink / raw)
To: airlied, daniel, jani.nikula, joonas.lahtinen, matthew.auld,
rodrigo.vivi, tvrtko.ursulin, ville.syrjala, yuehaibing
Cc: intel-gfx, dri-devel, linux-kernel
Quoting YueHaibing (2020-01-07 13:50:14)
> Fix build error:
> ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state:
> ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error:
> implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration]
> return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro));
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-07 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 13:50 [PATCH -next] drm/i915: Add missing include file <linux/math64.h> YueHaibing
2020-01-07 13:53 ` Chris Wilson
2020-01-07 14:02 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).