* [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings
@ 2020-01-04 20:43 Julia Lawall
2020-01-07 16:14 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2020-01-04 20:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: kbuild-all, Andrzej Hajda, Allison Randal, Jilayne Lovejoy,
Gustavo A. R. Silva, Steve Winslow, Thomas Gleixner, dri-devel,
linux-fbdev, linux-kernel
From: kbuild test robot <lkp@intel.com>
Remove dev_err() messages after platform_get_irq*() failures.
Line 450 is redundant because platform_get_irq() already prints
an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head: 80805774fc354f9ae7755a8e649a01dedfd0dcf8
commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
mmp_ctrl.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
ret = -ENOENT;
goto failed;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings
2020-01-04 20:43 [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings Julia Lawall
@ 2020-01-07 16:14 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2020-01-07 16:14 UTC (permalink / raw)
To: Julia Lawall
Cc: Bartlomiej Zolnierkiewicz, linux-fbdev, kbuild-all,
Gustavo A. R. Silva, linux-kernel, dri-devel, Steve Winslow,
Jilayne Lovejoy, Thomas Gleixner, Allison Randal
On Sat, Jan 04, 2020 at 09:43:31PM +0100, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
>
> Remove dev_err() messages after platform_get_irq*() failures.
> Line 450 is redundant because platform_get_irq() already prints
> an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Applied to drm-misc-next, thanks for your patch.
-Daniel
>
> ---
>
> tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> head: 80805774fc354f9ae7755a8e649a01dedfd0dcf8
> commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
> :::::: branch date: 11 hours ago
> :::::: commit date: 11 hours ago
>
> mmp_ctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
> ret = -ENOENT;
> goto failed;
> }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-07 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-04 20:43 [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings Julia Lawall
2020-01-07 16:14 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).