From: "Guido Günther" <agx@sigxcpu.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Exponential LED brightness Re: [PATCH v4 0/6] leds: lm3692x: Allow to set ovp and brigthness mode
Date: Wed, 8 Jan 2020 13:40:00 +0100 [thread overview]
Message-ID: <20200108124000.GA21245@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20200107133119.GA3825@duo.ucw.cz>
Hi Pavel,
On Tue, Jan 07, 2020 at 02:31:20PM +0100, Pavel Machek wrote:
> Hi!
>
> > Overvoltage protection and brightness mode are currently hardcoded
> > as 29V and disabled in the driver. Make these configurable via DT.
> >
> > This v4 moves the exponential brightness mode to the back of the series
> > as per Pavel's request:
> >
> > https://lore.kernel.org/linux-next/20200106103233.GA32426@amd/T/#m93270a9bf10b88e060f4e4cf5701c527476de985
> >
> > The end result is identical and i've tested everything still works when
> > dropping the last to patches and checked compiltion via
>
> Thank you. Applied 1-4 (with some reformatting of changelog, and
> led->LED).
>
> Exponential mode:
>
> We should decide if LEDs should be linear or not. Most LEDs are linear
> now, and we may want to make it part of the API. Additional advantage
> is that linear is "well defined". It is actually quite important for
> RGB LEDs, because you get wrong colors otherwise.
>
> (Non-linear can have advantages, too... like needing less bits.)
>
> So, my suggestion is to document LEDs as linear, and leave
> exponential->linear conversion to someone else.
That would mean doing a conversion in the kernel that can be done by the
chip. Would exposing non-linearity like in
/sys/class/backlight/<backlight>/scale be an option?
Cheers,
-- Guido
>
> Best regards,
>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2020-01-08 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:48 [PATCH v4 0/6] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2020-01-06 15:48 ` [PATCH v4 1/6] leds: lm3692x: Make sure we don't exceed the maximum led current Guido Günther
2020-01-06 15:48 ` [PATCH v4 2/6] leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enable Guido Günther
2020-01-06 15:48 ` [PATCH v4 3/6] leds: lm3692x: Split out lm3692x_leds_disable Guido Günther
2020-01-06 15:48 ` [PATCH v4 4/6] leds: lm3692x: Disable chip on brightness 0 Guido Günther
2020-01-06 15:48 ` [PATCH v4 5/6] dt: bindings: lm3692x: Add ti,brightness-mapping-exponential property Guido Günther
2020-01-06 15:48 ` [PATCH v4 6/6] leds: lm3692x: Allow to configure brigthness mode Guido Günther
2020-01-07 13:31 ` Exponential LED brightness Re: [PATCH v4 0/6] leds: lm3692x: Allow to set ovp and " Pavel Machek
2020-01-08 12:40 ` Guido Günther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108124000.GA21245@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).