From: "Guido Günther" <agx@sigxcpu.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 6/6] leds: lm3692x: Allow to configure brigthness mode
Date: Mon, 6 Jan 2020 16:48:55 +0100 [thread overview]
Message-ID: <95aaa83d98c9b91b4d87f6bcbf5f18082f8a1639.1578324703.git.agx@sigxcpu.org> (raw)
In-Reply-To: <cover.1578324703.git.agx@sigxcpu.org>
Brightness mode is currently hardcoded as linear in the driver. Make
exponential mode configurable via DT.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/leds/leds-lm3692x.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index 28a51aeb28de..933b786cfaec 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -239,8 +239,7 @@ static int lm3692x_leds_enable(struct lm3692x_led *led)
if (ret)
goto out;
- ret = regmap_write(led->regmap, LM3692X_BRT_CTRL,
- LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN);
+ ret = regmap_write(led->regmap, LM3692X_BRT_CTRL, led->brightness_ctrl);
if (ret)
goto out;
@@ -368,7 +367,12 @@ static enum led_brightness lm3692x_max_brightness(struct lm3692x_led *led,
u32 max_code;
/* see p.12 of LM36922 data sheet for brightness formula */
- max_code = ((max_cur * 1000) - 37806) / 12195;
+ if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
+ /* 228 =~ 1.0 / log2(1.003040572) */
+ max_code = ilog2(max_cur/50) * 228;
+ } else {
+ max_code = ((max_cur * 1000) - 37806) / 12195;
+ }
if (max_code > 0x7FF)
max_code = 0x7FF;
@@ -380,6 +384,7 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
struct fwnode_handle *child = NULL;
struct led_init_data init_data = {};
u32 ovp, max_cur;
+ bool exp_mode;
int ret;
led->enable_gpio = devm_gpiod_get_optional(&led->client->dev,
@@ -430,6 +435,12 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
}
}
+ led->brightness_ctrl = LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN;
+ exp_mode = device_property_read_bool(&led->client->dev,
+ "ti,brightness-mapping-exponential");
+ if (exp_mode)
+ led->brightness_ctrl |= LM3692X_MAP_MODE_EXP;
+
child = device_get_next_child_node(&led->client->dev, child);
if (!child) {
dev_err(&led->client->dev, "No LED Child node\n");
--
2.23.0
next prev parent reply other threads:[~2020-01-06 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:48 [PATCH v4 0/6] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2020-01-06 15:48 ` [PATCH v4 1/6] leds: lm3692x: Make sure we don't exceed the maximum led current Guido Günther
2020-01-06 15:48 ` [PATCH v4 2/6] leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enable Guido Günther
2020-01-06 15:48 ` [PATCH v4 3/6] leds: lm3692x: Split out lm3692x_leds_disable Guido Günther
2020-01-06 15:48 ` [PATCH v4 4/6] leds: lm3692x: Disable chip on brightness 0 Guido Günther
2020-01-06 15:48 ` [PATCH v4 5/6] dt: bindings: lm3692x: Add ti,brightness-mapping-exponential property Guido Günther
2020-01-06 15:48 ` Guido Günther [this message]
2020-01-07 13:31 ` Exponential LED brightness Re: [PATCH v4 0/6] leds: lm3692x: Allow to set ovp and brigthness mode Pavel Machek
2020-01-08 12:40 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95aaa83d98c9b91b4d87f6bcbf5f18082f8a1639.1578324703.git.agx@sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).