* [PATCH -next] soc: fsl: qe: remove set but not used variable 'mm_gc'
@ 2020-01-08 13:09 YueHaibing
2020-01-08 22:02 ` Li Yang
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-01-08 13:09 UTC (permalink / raw)
To: qiang.zhao, leoyang.li
Cc: linuxppc-dev, linux-arm-kernel, linux-kernel, YueHaibing
drivers/soc/fsl/qe/gpio.c: In function qe_pin_request:
drivers/soc/fsl/qe/gpio.c:163:26: warning: variable mm_gc set but not used [-Wunused-but-set-variable]
commit 1e714e54b5ca ("powerpc: qe_lib-gpio: use gpiochip data pointer")
left behind this unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/fsl/qe/gpio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c
index 12bdfd9..ed75198 100644
--- a/drivers/soc/fsl/qe/gpio.c
+++ b/drivers/soc/fsl/qe/gpio.c
@@ -160,7 +160,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index)
{
struct qe_pin *qe_pin;
struct gpio_chip *gc;
- struct of_mm_gpio_chip *mm_gc;
struct qe_gpio_chip *qe_gc;
int err;
unsigned long flags;
@@ -186,7 +185,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index)
goto err0;
}
- mm_gc = to_of_mm_gpio_chip(gc);
qe_gc = gpiochip_get_data(gc);
spin_lock_irqsave(&qe_gc->lock, flags);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] soc: fsl: qe: remove set but not used variable 'mm_gc'
2020-01-08 13:09 [PATCH -next] soc: fsl: qe: remove set but not used variable 'mm_gc' YueHaibing
@ 2020-01-08 22:02 ` Li Yang
0 siblings, 0 replies; 2+ messages in thread
From: Li Yang @ 2020-01-08 22:02 UTC (permalink / raw)
To: YueHaibing
Cc: Zhao Qiang, linuxppc-dev,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, lkml
On Wed, Jan 8, 2020 at 7:12 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/soc/fsl/qe/gpio.c: In function qe_pin_request:
> drivers/soc/fsl/qe/gpio.c:163:26: warning: variable mm_gc set but not used [-Wunused-but-set-variable]
>
> commit 1e714e54b5ca ("powerpc: qe_lib-gpio: use gpiochip data pointer")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied for next. Thanks.
Btw, I find another patch from Chen Zhou fixing the same problem sent
earlier. I will add his signed-off-by to the commit for credit too.
Regards,
Leo
> ---
> drivers/soc/fsl/qe/gpio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c
> index 12bdfd9..ed75198 100644
> --- a/drivers/soc/fsl/qe/gpio.c
> +++ b/drivers/soc/fsl/qe/gpio.c
> @@ -160,7 +160,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index)
> {
> struct qe_pin *qe_pin;
> struct gpio_chip *gc;
> - struct of_mm_gpio_chip *mm_gc;
> struct qe_gpio_chip *qe_gc;
> int err;
> unsigned long flags;
> @@ -186,7 +185,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index)
> goto err0;
> }
>
> - mm_gc = to_of_mm_gpio_chip(gc);
> qe_gc = gpiochip_get_data(gc);
>
> spin_lock_irqsave(&qe_gc->lock, flags);
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-08 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 13:09 [PATCH -next] soc: fsl: qe: remove set but not used variable 'mm_gc' YueHaibing
2020-01-08 22:02 ` Li Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).