* [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer
@ 2020-01-10 6:31 Nava kishore Manne
2020-01-10 20:53 ` Moritz Fischer
0 siblings, 1 reply; 2+ messages in thread
From: Nava kishore Manne @ 2020-01-10 6:31 UTC (permalink / raw)
To: mdf, michal.simek, linux-fpga, linux-arm-kernel, linux-kernel
Cc: Shubhrajyoti Datta
From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
In probe, the driver checks for devm_clk_get return and print error
message in the failing case. However for -EPROBE_DEFER this message
is confusing so avoid it.
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/fpga/xilinx-pr-decoupler.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index af9b387c56d3..7d69af230567 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -101,7 +101,8 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
priv->clk = devm_clk_get(&pdev->dev, "aclk");
if (IS_ERR(priv->clk)) {
- dev_err(&pdev->dev, "input clock not found\n");
+ if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "input clock not found\n");
return PTR_ERR(priv->clk);
}
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer
2020-01-10 6:31 [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer Nava kishore Manne
@ 2020-01-10 20:53 ` Moritz Fischer
0 siblings, 0 replies; 2+ messages in thread
From: Moritz Fischer @ 2020-01-10 20:53 UTC (permalink / raw)
To: Nava kishore Manne
Cc: mdf, michal.simek, linux-fpga, linux-arm-kernel, linux-kernel,
Shubhrajyoti Datta
On Fri, Jan 10, 2020 at 12:01:13PM +0530, Nava kishore Manne wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message
> is confusing so avoid it.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index af9b387c56d3..7d69af230567 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -101,7 +101,8 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(&pdev->dev, "aclk");
> if (IS_ERR(priv->clk)) {
> - dev_err(&pdev->dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
> --
> 2.18.0
>
Applied to for-next,
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-10 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 6:31 [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer Nava kishore Manne
2020-01-10 20:53 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).