linux-next: build warning after merge of the regulator tree

linux-next: build warning after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from drivers/regulator/mpq7920.c:19:
drivers/regulator/mpq7920.c: In function 'mpq7920_parse_cb':
drivers/regulator/mpq7920.c:224:13: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551551' to '4294967231' [-Woverflow]
  224 |     BIT(6), ~BIT(6));
include/linux/regmap.h:75:42: note: in definition of macro 'regmap_update_bits'
   75 |  regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
      |                                          ^~~

Introduced by commit

  6501c1f54a17 ("regulator: mpq7920: add mpq7920 regulator driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

On Tue, Oct 02, 2018 at 09:43:17AM +0300, Matti Vaittinen wrote:

> tree is correct way to go, right? I'll prepare one against Mark's branch
> "origin/topic/bd718xx". Mark, please let me know if you want me to send
> it or if I should do it on top of some other branch.

That branch is good, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the regulator tree

[Matti Vaittinen]

Hello Stephen, Mark & All,

On Tue, Oct 02, 2018 at 04:25:51PM +1000, Stephen Rothwell wrote:
> On Tue, 2 Oct 2018 09:16:44 +0300 Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote:
> >
> > On Tue, Oct 02, 2018 at 01:07:48PM +1000, Stephen Rothwell wrote:
> > > After merging the regulator tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > drivers/mfd/rohm-bd718x7.c: In function 'bd718xx_i2c_probe':
> > > drivers/mfd/rohm-bd718x7.c:101:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > >   bd718xx->chip_type = (unsigned int)  
> > 
> > I am pretty sure the last patch version corrected this to
> > +       bd71837->chip_type = (unsigned int)(uintptr_t)
> > +                               of_device_get_match_data(&i2c->dev);
> > 
> > is it possible one of the earlier versions has accidentally been
> > applied? Should I create patch on top of the last regulator tree or what
> > is the simplest way fix this?
> 
> Sorry, this came from commit
> 
>   dd2be639f4a9 ("regulator/mfd: bd718xx: rename bd71837/bd71847 common instances")
> 
> which is later than the commit I noted.  In this later commit, this happens:
> 
> -	bd71837->chip_irq = i2c->irq;
> -	bd71837->chip_type = (unsigned int)(uintptr_t)
> +	bd718xx->chip_irq = i2c->irq;
> +	bd718xx->chip_type = (unsigned int)
>  				of_device_get_match_data(&i2c->dev);

Right. So looks like I am still the guilty one then. I've overwritten
the fix in this rename patch which followed the corrected initial
support patch. I guess sending incremental patch with fix to regulator
tree is correct way to go, right? I'll prepare one against Mark's branch
"origin/topic/bd718xx". Mark, please let me know if you want me to send
it or if I should do it on top of some other branch.

Br,
	Matti Vaittinen

Re: linux-next: build warning after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Hi Matti,

On Tue, 2 Oct 2018 09:16:44 +0300 Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote:
>
> On Tue, Oct 02, 2018 at 01:07:48PM +1000, Stephen Rothwell wrote:
> > After merging the regulator tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/mfd/rohm-bd718x7.c: In function 'bd718xx_i2c_probe':
> > drivers/mfd/rohm-bd718x7.c:101:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   bd718xx->chip_type = (unsigned int)  
> 
> I am pretty sure the last patch version corrected this to
> +       bd71837->chip_type = (unsigned int)(uintptr_t)
> +                               of_device_get_match_data(&i2c->dev);
> 
> is it possible one of the earlier versions has accidentally been
> applied? Should I create patch on top of the last regulator tree or what
> is the simplest way fix this?

Sorry, this came from commit

  dd2be639f4a9 ("regulator/mfd: bd718xx: rename bd71837/bd71847 common instances")

which is later than the commit I noted.  In this later commit, this happens:

-	bd71837->chip_irq = i2c->irq;
-	bd71837->chip_type = (unsigned int)(uintptr_t)
+	bd718xx->chip_irq = i2c->irq;
+	bd718xx->chip_type = (unsigned int)
 				of_device_get_match_data(&i2c->dev);

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the regulator tree

[Matti Vaittinen]

Hello All,

On Tue, Oct 02, 2018 at 01:07:48PM +1000, Stephen Rothwell wrote:
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/mfd/rohm-bd718x7.c: In function 'bd718xx_i2c_probe':
> drivers/mfd/rohm-bd718x7.c:101:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   bd718xx->chip_type = (unsigned int)

I am pretty sure the last patch version corrected this to
+       bd71837->chip_type = (unsigned int)(uintptr_t)
+                               of_device_get_match_data(&i2c->dev);

is it possible one of the earlier versions has accidentally been
applied? Should I create patch on top of the last regulator tree or what
is the simplest way fix this?

Br,
	Matti Vaittinen

linux-next: build warning after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/mfd/rohm-bd718x7.c: In function 'bd718xx_i2c_probe':
drivers/mfd/rohm-bd718x7.c:101:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  bd718xx->chip_type = (unsigned int)
                       ^

Introduced by commit

  494edd266b94 ("regulator/mfd: Support ROHM BD71847 power management IC")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Mon, Apr 18, 2016 at 01:43:51PM +1000, Stephen Rothwell wrote:

> In the future, please fix up all the current users of an interface
> *before* marking it deprecated.  All these extra warnings just muddy the
> "real" warnings ...

Ideally but sadly all the issues are in the graphics stack and while
they seem relatively responsive to build issues there seems to be some
strange way of working there which means that getting changes integrated
or responses when issues like this come up has always been extremely
difficult and unfortunately cut'n'paste also seems to be quite common
(most of these look like they came from one place) so something to try
to at least give people pause for thought when they introduce new
issues seems sensible.

I really wish I could figure out what's going on there.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

linux-next: build warning after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_regulator_init':
drivers/gpu/drm/msm/dsi/dsi_host.c:329:3: warning: 'regulator_can_change_voltage' is deprecated [-Wdeprecated-declarations]
   if (regulator_can_change_voltage(s[i].consumer)) {
   ^

and several more ...

Introduced by commit

  6a0028b3dd67 ("regulator: Deprecate regulator_can_change_voltage()")

In the future, please fix up all the current users of an interface
*before* marking it deprecated.  All these extra warnings just muddy the
"real" warnings ...

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/regulator/core.c: At top level:
drivers/regulator/core.c:139:13: warning: 'regulator_lock_supply' defined but not used [-Wunused-function]
 static void regulator_lock_supply(struct regulator_dev *rdev)
             ^
drivers/regulator/core.c:159:13: warning: 'regulator_unlock_supply' defined but not used [-Wunused-function]
 static void regulator_unlock_supply(struct regulator_dev *rdev)
             ^

Introduced by commit

  9f01cd4a915e ("regulator: core: introduce function to lock regulators and its supplies")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au