* [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i
@ 2019-12-02 15:13 Colin King
2019-12-03 7:28 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2019-12-02 15:13 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable i is being initialized with a value that is never
read and it is being updated later with a new value in a for-loop.
The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/misc/ti-st/st_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index 2ae9948a91e1..6255d9b88122 100644
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers/misc/ti-st/st_core.c
@@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty)
static void st_tty_close(struct tty_struct *tty)
{
- unsigned char i = ST_MAX_CHANNELS;
+ unsigned char i;
unsigned long flags = 0;
struct st_data_s *st_gdata = tty->disc_data;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i
2019-12-02 15:13 [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i Colin King
@ 2019-12-03 7:28 ` Dan Carpenter
2020-01-11 20:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-12-03 7:28 UTC (permalink / raw)
To: Colin King
Cc: Arnd Bergmann, Greg Kroah-Hartman, kernel-janitors, linux-kernel
On Mon, Dec 02, 2019 at 03:13:52PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable i is being initialized with a value that is never
> read and it is being updated later with a new value in a for-loop.
> The initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/misc/ti-st/st_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
> index 2ae9948a91e1..6255d9b88122 100644
> --- a/drivers/misc/ti-st/st_core.c
> +++ b/drivers/misc/ti-st/st_core.c
> @@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty)
>
> static void st_tty_close(struct tty_struct *tty)
> {
> - unsigned char i = ST_MAX_CHANNELS;
> + unsigned char i;
> unsigned long flags = 0;
I'm surprised that flags doesn't generate a warning as well.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i
2019-12-03 7:28 ` Dan Carpenter
@ 2020-01-11 20:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-11 20:01 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Colin King, Arnd Bergmann, kernel-janitors, linux-kernel
On Tue, Dec 03, 2019 at 10:28:24AM +0300, Dan Carpenter wrote:
> On Mon, Dec 02, 2019 at 03:13:52PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The variable i is being initialized with a value that is never
> > read and it is being updated later with a new value in a for-loop.
> > The initialization is redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/misc/ti-st/st_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
> > index 2ae9948a91e1..6255d9b88122 100644
> > --- a/drivers/misc/ti-st/st_core.c
> > +++ b/drivers/misc/ti-st/st_core.c
> > @@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty)
> >
> > static void st_tty_close(struct tty_struct *tty)
> > {
> > - unsigned char i = ST_MAX_CHANNELS;
> > + unsigned char i;
> > unsigned long flags = 0;
>
> I'm surprised that flags doesn't generate a warning as well.
Yes, flags should be not initialized as well.
Colin, can you resend a v2 with that added?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-11 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 15:13 [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i Colin King
2019-12-03 7:28 ` Dan Carpenter
2020-01-11 20:01 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).