* [PATCH v2] PM / devfreq: Add debugfs support with devfreq_summary file
[not found] <CGME20200113045609epcas1p1188f24c37f8ba230a0e3856aeb0e4d8e@epcas1p1.samsung.com>
@ 2020-01-13 5:03 ` Chanwoo Choi
2020-01-13 18:18 ` Leonard Crestez
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2020-01-13 5:03 UTC (permalink / raw)
To: linux-pm, linux-kernel
Cc: leonard.crestez, lukasz.luba, a.swigon, m.szyprowski,
enric.balletbo, hl, digetx, bjorn.andersson, jcrouse, cw00.choi,
chanwoo, myungjoo.ham, kyungmin.park
Add debugfs interface to provide debugging information of devfreq device.
It contains 'devfreq_summary' entry to show the summary of registered
devfreq devices as following and the additional debugfs file will be added.
- /sys/kernel/debug/devfreq/devfreq_summary
[Detailed description of each field of 'devfreq_summary' debugfs file]
- dev_name : Device name of h/w.
- dev : Device name made by devfreq core.
- parent_dev : If devfreq device uses the passive governor,
show parent devfreq device name.
- governor : Devfreq governor.
- polling_ms : If devfreq device uses the simple_ondemand governor,
polling_ms is necessary for the period. (unit: millisecond)
- cur_freq_Hz : Current Frequency (unit: Hz)
- old_freq_Hz : Frequency before changing. (unit: Hz)
- new_freq_Hz : Frequency after changed. (unit: Hz)
[For example on Exynos5422-based Odroid-XU3 board]
$ cat /sys/kernel/debug/devfreq/devfreq_summary
dev_name dev parent_dev governor polling_ms cur_freq_Hz min_freq_Hz max_freq_Hz
------------------------------ ---------- ---------- --------------- ---------- ------------ ------------ ------------
10c20000.memory-controller devfreq0 simple_ondemand 0 165000000 165000000 825000000
soc:bus_wcore devfreq1 simple_ondemand 50 532000000 88700000 532000000
soc:bus_noc devfreq2 devfreq1 passive 0 111000000 66600000 111000000
soc:bus_fsys_apb devfreq3 devfreq1 passive 0 222000000 111000000 222000000
soc:bus_fsys devfreq4 devfreq1 passive 0 200000000 75000000 200000000
soc:bus_fsys2 devfreq5 devfreq1 passive 0 200000000 75000000 200000000
soc:bus_mfc devfreq6 devfreq1 passive 0 333000000 83250000 333000000
soc:bus_gen devfreq7 devfreq1 passive 0 266000000 88700000 266000000
soc:bus_peri devfreq8 devfreq1 passive 0 66600000 66600000 66600000
soc:bus_g2d devfreq9 devfreq1 passive 0 333000000 83250000 333000000
soc:bus_g2d_acp devfreq10 devfreq1 passive 0 266000000 66500000 266000000
soc:bus_jpeg devfreq11 devfreq1 passive 0 300000000 75000000 300000000
soc:bus_jpeg_apb devfreq12 devfreq1 passive 0 166500000 83250000 166500000
soc:bus_disp1_fimd devfreq13 devfreq1 passive 0 200000000 120000000 200000000
soc:bus_disp1 devfreq14 devfreq1 passive 0 300000000 120000000 300000000
soc:bus_gscl_scaler devfreq15 devfreq1 passive 0 300000000 150000000 300000000
soc:bus_mscl devfreq16 devfreq1 passive 0 666000000 84000000 666000000
[lkp: Reported the build error]
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes from v1:
- Drop the patch about 'devfreq_transitions' debugfs file
- Modify from 'hz' to 'Hz'
- Edit the indentation of 'devfreq_summary' when show summary
- Exchange sequence between PTR_ERR and IS_ERR when debugfs_create_dir
drivers/devfreq/devfreq.c | 84 +++++++++++++++++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 89260b17598f..c2ebed42704b 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/kmod.h>
#include <linux/sched.h>
+#include <linux/debugfs.h>
#include <linux/errno.h>
#include <linux/err.h>
#include <linux/init.h>
@@ -33,6 +34,7 @@
#define HZ_PER_KHZ 1000
static struct class *devfreq_class;
+static struct dentry *devfreq_debugfs;
/*
* devfreq core provides delayed work based load monitoring helper
@@ -1643,6 +1645,79 @@ static struct attribute *devfreq_attrs[] = {
};
ATTRIBUTE_GROUPS(devfreq);
+/**
+ * devfreq_summary_show() - Show the summary of the devfreq devices
+ * @s: seq_file instance to show the summary of devfreq devices
+ * @data: not used
+ *
+ * Show the summary of the devfreq devices via 'devfreq_summary' debugfs file.
+ * It helps that user can know the detailed information of the devfreq devices.
+ *
+ * Return 0 always because it shows the information without any data change.
+ */
+static int devfreq_summary_show(struct seq_file *s, void *data)
+{
+ struct devfreq *devfreq;
+ struct devfreq *p_devfreq = NULL;
+ unsigned long cur_freq, min_freq, max_freq;
+ unsigned int polling_ms;
+
+ seq_printf(s, "%-30s %-10s %-10s %-15s %10s %12s %12s %12s\n",
+ "dev_name",
+ "dev",
+ "parent_dev",
+ "governor",
+ "polling_ms",
+ "cur_freq_Hz",
+ "min_freq_Hz",
+ "max_freq_Hz");
+ seq_printf(s, "%30s %10s %10s %15s %10s %12s %12s %12s\n",
+ "------------------------------",
+ "----------",
+ "----------",
+ "---------------",
+ "----------",
+ "------------",
+ "------------",
+ "------------");
+
+ mutex_lock(&devfreq_list_lock);
+
+ list_for_each_entry_reverse(devfreq, &devfreq_list, node) {
+ if (!strncmp(devfreq->governor_name, DEVFREQ_GOV_PASSIVE,
+ DEVFREQ_NAME_LEN)) {
+ struct devfreq_passive_data *data = devfreq->data;
+
+ if (data)
+ p_devfreq = data->parent;
+ } else {
+ p_devfreq = NULL;
+ }
+
+ mutex_lock(&devfreq->lock);
+ cur_freq = devfreq->previous_freq,
+ get_freq_range(devfreq, &min_freq, &max_freq);
+ polling_ms = devfreq->profile->polling_ms,
+ mutex_unlock(&devfreq->lock);
+
+ seq_printf(s,
+ "%-30s %-10s %-10s %-15s %10d %12ld %12ld %12ld\n",
+ dev_name(devfreq->dev.parent),
+ dev_name(&devfreq->dev),
+ p_devfreq ? dev_name(&p_devfreq->dev) : "",
+ devfreq->governor_name,
+ polling_ms,
+ cur_freq,
+ min_freq,
+ max_freq);
+ }
+
+ mutex_unlock(&devfreq_list_lock);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(devfreq_summary);
+
static int __init devfreq_init(void)
{
devfreq_class = class_create(THIS_MODULE, "devfreq");
@@ -1659,6 +1734,15 @@ static int __init devfreq_init(void)
}
devfreq_class->dev_groups = devfreq_groups;
+ devfreq_debugfs = debugfs_create_dir("devfreq", NULL);
+ if (IS_ERR(devfreq_debugfs) && PTR_ERR(devfreq_debugfs) != -ENODEV) {
+ pr_warn("%s: couldn't create debugfs dir\n", __FILE__);
+ } else {
+ debugfs_create_file("devfreq_summary", 0444,
+ devfreq_debugfs, NULL,
+ &devfreq_summary_fops);
+ }
+
return 0;
}
subsys_initcall(devfreq_init);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PM / devfreq: Add debugfs support with devfreq_summary file
2020-01-13 5:03 ` [PATCH v2] PM / devfreq: Add debugfs support with devfreq_summary file Chanwoo Choi
@ 2020-01-13 18:18 ` Leonard Crestez
2020-01-14 1:41 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Leonard Crestez @ 2020-01-13 18:18 UTC (permalink / raw)
To: Chanwoo Choi
Cc: linux-pm, linux-kernel, lukasz.luba, a.swigon, m.szyprowski,
enric.balletbo, hl, digetx, bjorn.andersson, jcrouse, chanwoo,
myungjoo.ham, kyungmin.park
On 13.01.2020 06:56, Chanwoo Choi wrote:
> Add debugfs interface to provide debugging information of devfreq device.
> It contains 'devfreq_summary' entry to show the summary of registered
> devfreq devices as following and the additional debugfs file will be added.
> - /sys/kernel/debug/devfreq/devfreq_summary
>
> [Detailed description of each field of 'devfreq_summary' debugfs file]
> - dev_name : Device name of h/w.
> - dev : Device name made by devfreq core.
> - parent_dev : If devfreq device uses the passive governor,
> show parent devfreq device name.
> - governor : Devfreq governor.
> - polling_ms : If devfreq device uses the simple_ondemand governor,
> polling_ms is necessary for the period. (unit: millisecond)
> - cur_freq_Hz : Current Frequency (unit: Hz)
> - old_freq_Hz : Frequency before changing. (unit: Hz)
> - new_freq_Hz : Frequency after changed. (unit: Hz)
>
> [For example on Exynos5422-based Odroid-XU3 board]
> $ cat /sys/kernel/debug/devfreq/devfreq_summary
> dev_name dev parent_dev governor polling_ms cur_freq_Hz min_freq_Hz max_freq_Hz
> ------------------------------ ---------- ---------- --------------- ---------- ------------ ------------ ------------
> 10c20000.memory-controller devfreq0 simple_ondemand 0 165000000 165000000 825000000
> soc:bus_wcore devfreq1 simple_ondemand 50 532000000 88700000 532000000
> soc:bus_noc devfreq2 devfreq1 passive 0 111000000 66600000 111000000
> soc:bus_fsys_apb devfreq3 devfreq1 passive 0 222000000 111000000 222000000
> soc:bus_fsys devfreq4 devfreq1 passive 0 200000000 75000000 200000000
> soc:bus_fsys2 devfreq5 devfreq1 passive 0 200000000 75000000 200000000
> soc:bus_mfc devfreq6 devfreq1 passive 0 333000000 83250000 333000000
> soc:bus_gen devfreq7 devfreq1 passive 0 266000000 88700000 266000000
> soc:bus_peri devfreq8 devfreq1 passive 0 66600000 66600000 66600000
> soc:bus_g2d devfreq9 devfreq1 passive 0 333000000 83250000 333000000
> soc:bus_g2d_acp devfreq10 devfreq1 passive 0 266000000 66500000 266000000
> soc:bus_jpeg devfreq11 devfreq1 passive 0 300000000 75000000 300000000
> soc:bus_jpeg_apb devfreq12 devfreq1 passive 0 166500000 83250000 166500000
> soc:bus_disp1_fimd devfreq13 devfreq1 passive 0 200000000 120000000 200000000
> soc:bus_disp1 devfreq14 devfreq1 passive 0 300000000 120000000 300000000
> soc:bus_gscl_scaler devfreq15 devfreq1 passive 0 300000000 150000000 300000000
> soc:bus_mscl devfreq16 devfreq1 passive 0 666000000 84000000 666000000
>
> [lkp: Reported the build error]
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes from v1:
> - Drop the patch about 'devfreq_transitions' debugfs file
> - Modify from 'hz' to 'Hz'
> - Edit the indentation of 'devfreq_summary' when show summary
> - Exchange sequence between PTR_ERR and IS_ERR when debugfs_create_dir
>
> drivers/devfreq/devfreq.c | 84 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 89260b17598f..c2ebed42704b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/kmod.h>
> #include <linux/sched.h>
> +#include <linux/debugfs.h>
> #include <linux/errno.h>
> #include <linux/err.h>
> #include <linux/init.h>
> @@ -33,6 +34,7 @@
> #define HZ_PER_KHZ 1000
>
> static struct class *devfreq_class;
> +static struct dentry *devfreq_debugfs;
>
> /*
> * devfreq core provides delayed work based load monitoring helper
> @@ -1643,6 +1645,79 @@ static struct attribute *devfreq_attrs[] = {
> };
> ATTRIBUTE_GROUPS(devfreq);
>
> +/**
> + * devfreq_summary_show() - Show the summary of the devfreq devices
> + * @s: seq_file instance to show the summary of devfreq devices
> + * @data: not used
> + *
> + * Show the summary of the devfreq devices via 'devfreq_summary' debugfs file.
> + * It helps that user can know the detailed information of the devfreq devices.
> + *
> + * Return 0 always because it shows the information without any data change.
> + */
> +static int devfreq_summary_show(struct seq_file *s, void *data)
> +{
> + struct devfreq *devfreq;
> + struct devfreq *p_devfreq = NULL;
> + unsigned long cur_freq, min_freq, max_freq;
> + unsigned int polling_ms;
> +
> + seq_printf(s, "%-30s %-10s %-10s %-15s %10s %12s %12s %12s\n",
> + "dev_name",
> + "dev",
> + "parent_dev",
> + "governor",
> + "polling_ms",
> + "cur_freq_Hz",
> + "min_freq_Hz",
> + "max_freq_Hz");
> + seq_printf(s, "%30s %10s %10s %15s %10s %12s %12s %12s\n",
> + "------------------------------",
> + "----------",
> + "----------",
> + "---------------",
> + "----------",
> + "------------",
> + "------------",
> + "------------");
> +
> + mutex_lock(&devfreq_list_lock);
> +
> + list_for_each_entry_reverse(devfreq, &devfreq_list, node) {
> + if (!strncmp(devfreq->governor_name, DEVFREQ_GOV_PASSIVE,
> + DEVFREQ_NAME_LEN)) {
> + struct devfreq_passive_data *data = devfreq->data;
> +
> + if (data)
> + p_devfreq = data->parent;
> + } else {
> + p_devfreq = NULL;
> + }
> +
> + mutex_lock(&devfreq->lock);
> + cur_freq = devfreq->previous_freq,
> + get_freq_range(devfreq, &min_freq, &max_freq);
> + polling_ms = devfreq->profile->polling_ms,
> + mutex_unlock(&devfreq->lock);
> +
> + seq_printf(s,
> + "%-30s %-10s %-10s %-15s %10d %12ld %12ld %12ld\n",
> + dev_name(devfreq->dev.parent),
> + dev_name(&devfreq->dev),
> + p_devfreq ? dev_name(&p_devfreq->dev) : "",
Can you prints some sort of "null" here instead of just skipping the field?
This would ensure output is always a whitespace-separated table that can
be easily processed with tools like "awk".
> + devfreq->governor_name,
> + polling_ms,
> + cur_freq,
> + min_freq,
> + max_freq);
> + }
> +
> + mutex_unlock(&devfreq_list_lock);
> +
> + return 0;
> +}
> +DEFINE_SHOW_ATTRIBUTE(devfreq_summary);
> +
> static int __init devfreq_init(void)
> {
> devfreq_class = class_create(THIS_MODULE, "devfreq");
> @@ -1659,6 +1734,15 @@ static int __init devfreq_init(void)
> }
> devfreq_class->dev_groups = devfreq_groups;
>
> + devfreq_debugfs = debugfs_create_dir("devfreq", NULL);
> + if (IS_ERR(devfreq_debugfs) && PTR_ERR(devfreq_debugfs) != -ENODEV) {
> + pr_warn("%s: couldn't create debugfs dir\n", __FILE__); > + } else {
> + debugfs_create_file("devfreq_summary", 0444,
> + devfreq_debugfs, NULL,
> + &devfreq_summary_fops);
> + }
> +
> return 0;
> }
> subsys_initcall(devfreq_init);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PM / devfreq: Add debugfs support with devfreq_summary file
2020-01-13 18:18 ` Leonard Crestez
@ 2020-01-14 1:41 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2020-01-14 1:41 UTC (permalink / raw)
To: Leonard Crestez
Cc: linux-pm, linux-kernel, lukasz.luba, a.swigon, m.szyprowski,
enric.balletbo, hl, digetx, bjorn.andersson, jcrouse, chanwoo,
myungjoo.ham, kyungmin.park
On 1/14/20 3:18 AM, Leonard Crestez wrote:
> On 13.01.2020 06:56, Chanwoo Choi wrote:
>> Add debugfs interface to provide debugging information of devfreq device.
>> It contains 'devfreq_summary' entry to show the summary of registered
>> devfreq devices as following and the additional debugfs file will be added.
>> - /sys/kernel/debug/devfreq/devfreq_summary
>>
>> [Detailed description of each field of 'devfreq_summary' debugfs file]
>> - dev_name : Device name of h/w.
>> - dev : Device name made by devfreq core.
>> - parent_dev : If devfreq device uses the passive governor,
>> show parent devfreq device name.
>> - governor : Devfreq governor.
>> - polling_ms : If devfreq device uses the simple_ondemand governor,
>> polling_ms is necessary for the period. (unit: millisecond)
>> - cur_freq_Hz : Current Frequency (unit: Hz)
>> - old_freq_Hz : Frequency before changing. (unit: Hz)
>> - new_freq_Hz : Frequency after changed. (unit: Hz)
>>
>> [For example on Exynos5422-based Odroid-XU3 board]
>> $ cat /sys/kernel/debug/devfreq/devfreq_summary
>> dev_name dev parent_dev governor polling_ms cur_freq_Hz min_freq_Hz max_freq_Hz
>> ------------------------------ ---------- ---------- --------------- ---------- ------------ ------------ ------------
>> 10c20000.memory-controller devfreq0 simple_ondemand 0 165000000 165000000 825000000
>> soc:bus_wcore devfreq1 simple_ondemand 50 532000000 88700000 532000000
>> soc:bus_noc devfreq2 devfreq1 passive 0 111000000 66600000 111000000
>> soc:bus_fsys_apb devfreq3 devfreq1 passive 0 222000000 111000000 222000000
>> soc:bus_fsys devfreq4 devfreq1 passive 0 200000000 75000000 200000000
>> soc:bus_fsys2 devfreq5 devfreq1 passive 0 200000000 75000000 200000000
>> soc:bus_mfc devfreq6 devfreq1 passive 0 333000000 83250000 333000000
>> soc:bus_gen devfreq7 devfreq1 passive 0 266000000 88700000 266000000
>> soc:bus_peri devfreq8 devfreq1 passive 0 66600000 66600000 66600000
>> soc:bus_g2d devfreq9 devfreq1 passive 0 333000000 83250000 333000000
>> soc:bus_g2d_acp devfreq10 devfreq1 passive 0 266000000 66500000 266000000
>> soc:bus_jpeg devfreq11 devfreq1 passive 0 300000000 75000000 300000000
>> soc:bus_jpeg_apb devfreq12 devfreq1 passive 0 166500000 83250000 166500000
>> soc:bus_disp1_fimd devfreq13 devfreq1 passive 0 200000000 120000000 200000000
>> soc:bus_disp1 devfreq14 devfreq1 passive 0 300000000 120000000 300000000
>> soc:bus_gscl_scaler devfreq15 devfreq1 passive 0 300000000 150000000 300000000
>> soc:bus_mscl devfreq16 devfreq1 passive 0 666000000 84000000 666000000
>>
>> [lkp: Reported the build error]
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> Changes from v1:
>> - Drop the patch about 'devfreq_transitions' debugfs file
>> - Modify from 'hz' to 'Hz'
>> - Edit the indentation of 'devfreq_summary' when show summary
>> - Exchange sequence between PTR_ERR and IS_ERR when debugfs_create_dir
>>
>> drivers/devfreq/devfreq.c | 84 +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 84 insertions(+)
>>
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 89260b17598f..c2ebed42704b 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -10,6 +10,7 @@
>> #include <linux/kernel.h>
>> #include <linux/kmod.h>
>> #include <linux/sched.h>
>> +#include <linux/debugfs.h>
>> #include <linux/errno.h>
>> #include <linux/err.h>
>> #include <linux/init.h>
>> @@ -33,6 +34,7 @@
>> #define HZ_PER_KHZ 1000
>>
>> static struct class *devfreq_class;
>> +static struct dentry *devfreq_debugfs;
>>
>> /*
>> * devfreq core provides delayed work based load monitoring helper
>> @@ -1643,6 +1645,79 @@ static struct attribute *devfreq_attrs[] = {
>> };
>> ATTRIBUTE_GROUPS(devfreq);
>>
>> +/**
>> + * devfreq_summary_show() - Show the summary of the devfreq devices
>> + * @s: seq_file instance to show the summary of devfreq devices
>> + * @data: not used
>> + *
>> + * Show the summary of the devfreq devices via 'devfreq_summary' debugfs file.
>> + * It helps that user can know the detailed information of the devfreq devices.
>> + *
>> + * Return 0 always because it shows the information without any data change.
>> + */
>> +static int devfreq_summary_show(struct seq_file *s, void *data)
>> +{
>> + struct devfreq *devfreq;
>> + struct devfreq *p_devfreq = NULL;
>> + unsigned long cur_freq, min_freq, max_freq;
>> + unsigned int polling_ms;
>> +
>> + seq_printf(s, "%-30s %-10s %-10s %-15s %10s %12s %12s %12s\n",
>> + "dev_name",
>> + "dev",
>> + "parent_dev",
>> + "governor",
>> + "polling_ms",
>> + "cur_freq_Hz",
>> + "min_freq_Hz",
>> + "max_freq_Hz");
>> + seq_printf(s, "%30s %10s %10s %15s %10s %12s %12s %12s\n",
>> + "------------------------------",
>> + "----------",
>> + "----------",
>> + "---------------",
>> + "----------",
>> + "------------",
>> + "------------",
>> + "------------");
>> +
>> + mutex_lock(&devfreq_list_lock);
>> +
>> + list_for_each_entry_reverse(devfreq, &devfreq_list, node) {
>> + if (!strncmp(devfreq->governor_name, DEVFREQ_GOV_PASSIVE,
>> + DEVFREQ_NAME_LEN)) {
>> + struct devfreq_passive_data *data = devfreq->data;
>> +
>> + if (data)
>> + p_devfreq = data->parent;
>> + } else {
>> + p_devfreq = NULL;
>> + }
>> +
>> + mutex_lock(&devfreq->lock);
>> + cur_freq = devfreq->previous_freq,
>> + get_freq_range(devfreq, &min_freq, &max_freq);
>> + polling_ms = devfreq->profile->polling_ms,
>> + mutex_unlock(&devfreq->lock);
>> +
>> + seq_printf(s,
>> + "%-30s %-10s %-10s %-15s %10d %12ld %12ld %12ld\n",
>> + dev_name(devfreq->dev.parent),
>> + dev_name(&devfreq->dev),
>> + p_devfreq ? dev_name(&p_devfreq->dev) : "",
>
> Can you prints some sort of "null" here instead of just skipping the field?
>
> This would ensure output is always a whitespace-separated table that can
> be easily processed with tools like "awk".
OK.
I had considered what is better to show 'null' or not.
If there is requirement, print 'null'.
>
>> + devfreq->governor_name,
>> + polling_ms,
>> + cur_freq,
>> + min_freq,
>> + max_freq);
>> + }
>> +
>> + mutex_unlock(&devfreq_list_lock);
>> +
>> + return 0;
>> +}
>> +DEFINE_SHOW_ATTRIBUTE(devfreq_summary);
>> +
>> static int __init devfreq_init(void)
>> {
>> devfreq_class = class_create(THIS_MODULE, "devfreq");
>> @@ -1659,6 +1734,15 @@ static int __init devfreq_init(void)
>> }
>> devfreq_class->dev_groups = devfreq_groups;
>>
>> + devfreq_debugfs = debugfs_create_dir("devfreq", NULL);
>> + if (IS_ERR(devfreq_debugfs) && PTR_ERR(devfreq_debugfs) != -ENODEV) {
>> + pr_warn("%s: couldn't create debugfs dir\n", __FILE__); > + } else {
>> + debugfs_create_file("devfreq_summary", 0444,
>> + devfreq_debugfs, NULL,
>> + &devfreq_summary_fops);
>> + }
>> +
>> return 0;
>> }
>> subsys_initcall(devfreq_init);
>>
>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] PM / devfreq: Add debugfs support with devfreq_summary file
[not found] <CGME20200103010658epcas1p44ecdbebc9ac9dda57e5d42ee39c25d8e@epcas1p4.samsung.com>
@ 2020-01-03 1:13 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2020-01-03 1:13 UTC (permalink / raw)
To: linux-pm, linux-kernel
Cc: cw00.choi, chanwoo, myungjoo.ham, kyungmin.park, natechancellor
Add debugfs interface to provide debugging information of devfreq device.
It contains 'devfreq_summary' entry to show the summary of registered
devfreq devices as following and the additional debugfs file will be added.
- /sys/kernel/debug/devfreq/devfreq_summary
[For example on Exynos5422-based Odroid-XU3 board]
- In order to show the multiple governors on devfreq_summay result,
change the governor of devfreq0 from simple_ondemand to userspace.
$ cat /sys/kernel/debug/devfreq/devfreq_summary
dev name dev parent dev governor cur_freq min_freq max_freq
------------------------------ ---------- ---------- --------------- ------------ ------------ ------------
10c20000.memory-controller devfreq0 userspace 165000000 165000000 825000000
soc:bus_wcore devfreq1 simple_ondemand 400000000 84000000 400000000
soc:bus_noc devfreq2 devfreq1 passive 100000000 67000000 100000000
soc:bus_fsys_apb devfreq3 devfreq1 passive 200000000 100000000 200000000
soc:bus_fsys devfreq4 devfreq1 passive 200000000 100000000 200000000
soc:bus_fsys2 devfreq5 devfreq1 passive 150000000 75000000 150000000
soc:bus_mfc devfreq6 devfreq1 passive 333000000 96000000 333000000
soc:bus_gen devfreq7 devfreq1 passive 267000000 89000000 267000000
soc:bus_peri devfreq8 devfreq1 passive 67000000 67000000 67000000
soc:bus_g2d devfreq9 devfreq1 passive 333000000 84000000 333000000
soc:bus_g2d_acp devfreq10 devfreq1 passive 267000000 67000000 267000000
soc:bus_jpeg devfreq11 devfreq1 passive 300000000 75000000 300000000
soc:bus_jpeg_apb devfreq12 devfreq1 passive 167000000 84000000 167000000
soc:bus_disp1_fimd devfreq13 devfreq1 passive 200000000 120000000 200000000
soc:bus_disp1 devfreq14 devfreq1 passive 300000000 120000000 300000000
soc:bus_gscl_scaler devfreq15 devfreq1 passive 300000000 150000000 300000000
soc:bus_mscl devfreq16 devfreq1 passive 400000000 84000000 400000000
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes from v1:
- Handle exception case when DEVFREQ_GOV_PASSIVE is unset.
drivers/devfreq/devfreq.c | 68 +++++++++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index acd21345a070..44feade5977d 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/kmod.h>
#include <linux/sched.h>
+#include <linux/debugfs.h>
#include <linux/errno.h>
#include <linux/err.h>
#include <linux/init.h>
@@ -33,6 +34,7 @@
#define HZ_PER_KHZ 1000
static struct class *devfreq_class;
+static struct dentry *devfreq_debugfs;
/*
* devfreq core provides delayed work based load monitoring helper
@@ -1670,6 +1672,64 @@ static struct attribute *devfreq_attrs[] = {
};
ATTRIBUTE_GROUPS(devfreq);
+static int devfreq_summary_show(struct seq_file *s, void *data)
+{
+ struct devfreq *devfreq;
+ struct devfreq *parent_devfreq = NULL;
+ unsigned long cur_freq, min_freq, max_freq;
+
+ seq_printf(s, "%-30s %-10s %-10s %-15s %-12s %-12s %-12s\n",
+ "dev name",
+ "dev",
+ "parent dev",
+ "governor",
+ "cur_freq",
+ "min_freq",
+ "max_freq");
+ seq_printf(s, "%-30s %-10s %-10s %-15s %-12s %-12s %-12s\n",
+ "------------------------------",
+ "----------",
+ "----------",
+ "---------------",
+ "------------",
+ "------------",
+ "------------");
+
+ mutex_lock(&devfreq_list_lock);
+
+ list_for_each_entry_reverse(devfreq, &devfreq_list, node) {
+#if IS_ENABLED(CONFIG_DEVFREQ_GOV_PASSIVE)
+ if (!strncmp(devfreq->governor_name, DEVFREQ_GOV_PASSIVE,
+ DEVFREQ_NAME_LEN)) {
+ struct devfreq_passive_data *data = devfreq->data;
+
+ if (data)
+ parent_devfreq = data->parent;
+ } else {
+ parent_devfreq = NULL;
+ }
+#endif
+ mutex_lock(&devfreq->lock);
+ cur_freq = devfreq->previous_freq,
+ get_freq_range(devfreq, &min_freq, &max_freq);
+ mutex_unlock(&devfreq->lock);
+
+ seq_printf(s, "%-30s %-10s %-10s %-15s %-12ld %-12ld %-12ld\n",
+ dev_name(devfreq->dev.parent),
+ dev_name(&devfreq->dev),
+ parent_devfreq ? dev_name(&parent_devfreq->dev) : "",
+ devfreq->governor_name,
+ cur_freq,
+ min_freq,
+ max_freq);
+ }
+
+ mutex_unlock(&devfreq_list_lock);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(devfreq_summary);
+
static int __init devfreq_init(void)
{
devfreq_class = class_create(THIS_MODULE, "devfreq");
@@ -1686,6 +1746,14 @@ static int __init devfreq_init(void)
}
devfreq_class->dev_groups = devfreq_groups;
+ devfreq_debugfs = debugfs_create_dir("devfreq", NULL);
+ if (PTR_ERR(devfreq_debugfs) != -ENODEV && IS_ERR(devfreq_debugfs)) {
+ pr_warn("%s: couldn't create debugfs dir\n", __FILE__);
+ } else {
+ debugfs_create_file("devfreq_summary", 0444, devfreq_debugfs,
+ NULL, &devfreq_summary_fops);
+ }
+
return 0;
}
subsys_initcall(devfreq_init);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-14 1:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200113045609epcas1p1188f24c37f8ba230a0e3856aeb0e4d8e@epcas1p1.samsung.com>
2020-01-13 5:03 ` [PATCH v2] PM / devfreq: Add debugfs support with devfreq_summary file Chanwoo Choi
2020-01-13 18:18 ` Leonard Crestez
2020-01-14 1:41 ` Chanwoo Choi
[not found] <CGME20200103010658epcas1p44ecdbebc9ac9dda57e5d42ee39c25d8e@epcas1p4.samsung.com>
2020-01-03 1:13 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).