[PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

[PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

[Chen Zhou]

If CONFIG_SND_ATMEL_SOC_DMA=m, build error:

sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'

Function atmel_pcm_dma_platform_register is defined under
CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in
CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
 sound/soc/atmel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index f118c22..d1dc8e6 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
 
 config SND_ATMEL_SOC_SSC
 	tristate
+	select SND_ATMEL_SOC_DMA
+	select SND_ATMEL_SOC_PDC
 
 config SND_ATMEL_SOC_SSC_PDC
 	tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
-- 
2.7.4

Re: [PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

On Mon, Jan 13, 2020 at 09:32:42PM +0800, Chen Zhou wrote:
> If CONFIG_SND_ATMEL_SOC_DMA=m, build error:
> 
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'

You should make sure to CC maintainers on patches, that includes
driver-specific maintainers (as is the case for this one), it's
fine in this case so no need to resend but please bear this in
mind in future.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

[Codrin.Ciubotariu]

On 13.01.2020 15:32, Chen Zhou wrote:
> If CONFIG_SND_ATMEL_SOC_DMA=m, build error:
> 
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'
> 
> Function atmel_pcm_dma_platform_register is defined under
> CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in
> CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.

Arnd sent a more complete patch for this issue:
https://lkml.org/lkml/2019/10/1/620

It wasn't merged due to some integration issues. Could you please try it 
and let us know if it fixes your issue?

Thanks and best regards,
Codrin

> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
>   sound/soc/atmel/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..d1dc8e6 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
> 
>   config SND_ATMEL_SOC_SSC
>          tristate
> +       select SND_ATMEL_SOC_DMA
> +       select SND_ATMEL_SOC_PDC
> 
>   config SND_ATMEL_SOC_SSC_PDC
>          tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> --
> 2.7.4
>