linux-next: Signed-off-by missing for commit in the random tree

linux-next: Signed-off-by missing for commit in the random tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi all,

Commit

  1b710b1b10ef ("char/random: silence a lockdep splat with printk()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the random tree

[Theodore Y. Ts'o]

On Wed, Jan 08, 2020 at 11:39:53AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1b710b1b10ef ("char/random: silence a lockdep splat with printk()")
> 
> is missing a Signed-off-by from its author.

Sergey, can you confirm that you intended to add a Signed-off-by: for
this patch?

Thanks!!

						- Ted

Re: linux-next: Signed-off-by missing for commit in the random tree

[Sergey Senozhatsky]

On (20/01/13 19:18), Theodore Y. Ts'o wrote:
> On Wed, Jan 08, 2020 at 11:39:53AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   1b710b1b10ef ("char/random: silence a lockdep splat with printk()")
> > 
> > is missing a Signed-off-by from its author.
> 
> Sergey, can you confirm that you intended to add a Signed-off-by: for
> this patch?

Oh, I didn't realize I was the author. Sorry!

Sure, confirmed

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>

	-ss

Re: linux-next: Signed-off-by missing for commit in the random tree

[Theodore Y. Ts'o]

On Tue, Jan 14, 2020 at 10:22:21AM +0900, Sergey Senozhatsky wrote:
> 
> Oh, I didn't realize I was the author. Sorry!
> 
> Sure, confirmed
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
>

Hmm... the e-mail in question[1] was sent by Qian Cai, but there was a

   From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>

in the first line of the body which attributed the patch to you.  But
then e-mail continues:

   Sergey didn't like the locking order .... but those code is so old,
   and I have no clue how to de-couple it after checking other locks in
   the splat. There is an onging effort to make all printk() as deferred,
   so until that happens, workaround it for now as a short-term fix.

So did Qian Cai author the patch, and this should have been
"Reported-by Sergey Senozhatsky"?  In which case I need a
Signed-off-by from Qian Cai.

This is a pretty trivial patch, but it would be good to get the
attributions and credit correct!

						- Ted

[1] https://lore.kernel.org/linux-arm-kernel/1573679785-21068-1-git-send-email-cai@lca.pw/

Re: linux-next: Signed-off-by missing for commit in the random tree

[Qian Cai]

> On Jan 14, 2020, at 11:57 AM, Theodore Y. Ts'o <tytso@mit.edu> wrote:
> 
> On Tue, Jan 14, 2020 at 10:22:21AM +0900, Sergey Senozhatsky wrote:
>> 
>> Oh, I didn't realize I was the author. Sorry!
>> 
>> Sure, confirmed
>> 
>> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
>> 
> 
> Hmm... the e-mail in question[1] was sent by Qian Cai, but there was a
> 
>   From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> 
> in the first line of the body which attributed the patch to you.  But
> then e-mail continues:
> 
>   Sergey didn't like the locking order .... but those code is so old,
>   and I have no clue how to de-couple it after checking other locks in
>   the splat. There is an onging effort to make all printk() as deferred,
>   so until that happens, workaround it for now as a short-term fix.
> 
> So did Qian Cai author the patch, and this should have been
> "Reported-by Sergey Senozhatsky"?  In which case I need a
> Signed-off-by from Qian Cai.
> 
> This is a pretty trivial patch, but it would be good to get the
> attributions and credit correct!
> 
> 						- Ted
> 
> [1] https://lore.kernel.org/linux-arm-kernel/1573679785-21068-1-git-send-email-cai@lca.pw/

It is actually Sergey proposed an informal patch here [1]. I just sent on
his behave and adding a commit log.

[1] https://lore.kernel.org/linux-mm/20190911011008.GA4420@jagdpanzerIV/ 

Re: linux-next: Signed-off-by missing for commit in the random tree

[Theodore Y. Ts'o]

On Tue, Jan 14, 2020 at 12:31:04PM -0500, Qian Cai wrote:
> It is actually Sergey proposed an informal patch here [1]. I just sent on
> his behave and adding a commit log.
> 
> [1] https://lore.kernel.org/linux-mm/20190911011008.GA4420@jagdpanzerIV/ 
> 

Thanks for the clarification; given that you composed the commit log,
would you like me to add a "Signed-off-by: Qian Cai <cai@lca.pw>" for
you as well?  Given that you added the commit description, it would be
fair to give you credit as well.

Regards,

					- Ted

Re: linux-next: Signed-off-by missing for commit in the random tree

[Qian Cai]

> On Jan 14, 2020, at 4:33 PM, Theodore Y. Ts'o <tytso@mit.edu> wrote:
> 
> Thanks for the clarification; given that you composed the commit log,
> would you like me to add a "Signed-off-by: Qian Cai <cai@lca.pw>" for
> you as well?  Given that you added the commit description, it would be
> fair to give you credit as well.

Yes, the patch has already had my SoB.