* [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write
@ 2020-01-14 14:40 Colin King
2020-01-14 15:50 ` Asmaa Mnebhi
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2020-01-14 14:40 UTC (permalink / raw)
To: Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman, vadimp,
Asmaa Mnebhi, openipmi-developer
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The end of buffer check is off-by-one since the check is against
an index that is pre-incremented before a store to buf[]. Fix this
adjusting the bounds check appropriately.
Addresses-Coverity: ("Out-of-bounds write")
Fixes: 51bd6f291583 ("Add support for IPMB driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/ipmi/ipmb_dev_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
index 9fdae83e59e0..382b28f1cf2f 100644
--- a/drivers/char/ipmi/ipmb_dev_int.c
+++ b/drivers/char/ipmi/ipmb_dev_int.c
@@ -279,7 +279,7 @@ static int ipmb_slave_cb(struct i2c_client *client,
break;
case I2C_SLAVE_WRITE_RECEIVED:
- if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg))
+ if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg) - 1)
break;
buf[++ipmb_dev->msg_idx] = *val;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write
2020-01-14 14:40 [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write Colin King
@ 2020-01-14 15:50 ` Asmaa Mnebhi
2020-01-20 17:01 ` Corey Minyard
0 siblings, 1 reply; 3+ messages in thread
From: Asmaa Mnebhi @ 2020-01-14 15:50 UTC (permalink / raw)
To: Colin King, Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman,
Vadim Pasternak, openipmi-developer
Cc: kernel-janitors, linux-kernel
Reviewed-by: Asmaa Mnebhi <asmaa@mellanox.com>
-----Original Message-----
From: Colin King <colin.king@canonical.com>
Sent: Tuesday, January 14, 2020 9:41 AM
To: Corey Minyard <cminyard@mvista.com>; Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Vadim Pasternak <vadimp@mellanox.com>; Asmaa Mnebhi <Asmaa@mellanox.com>; openipmi-developer@lists.sourceforge.net
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write
From: Colin Ian King <colin.king@canonical.com>
The end of buffer check is off-by-one since the check is against an index that is pre-incremented before a store to buf[]. Fix this adjusting the bounds check appropriately.
Addresses-Coverity: ("Out-of-bounds write")
Fixes: 51bd6f291583 ("Add support for IPMB driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/ipmi/ipmb_dev_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
index 9fdae83e59e0..382b28f1cf2f 100644
--- a/drivers/char/ipmi/ipmb_dev_int.c
+++ b/drivers/char/ipmi/ipmb_dev_int.c
@@ -279,7 +279,7 @@ static int ipmb_slave_cb(struct i2c_client *client,
break;
case I2C_SLAVE_WRITE_RECEIVED:
- if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg))
+ if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg) - 1)
break;
buf[++ipmb_dev->msg_idx] = *val;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write
2020-01-14 15:50 ` Asmaa Mnebhi
@ 2020-01-20 17:01 ` Corey Minyard
0 siblings, 0 replies; 3+ messages in thread
From: Corey Minyard @ 2020-01-20 17:01 UTC (permalink / raw)
To: Asmaa Mnebhi
Cc: Colin King, Arnd Bergmann, Greg Kroah-Hartman, Vadim Pasternak,
openipmi-developer, kernel-janitors, linux-kernel
On Tue, Jan 14, 2020 at 03:50:22PM +0000, Asmaa Mnebhi wrote:
> Reviewed-by: Asmaa Mnebhi <asmaa@mellanox.com>
Thanks, I've picked this up in my next tree.
-corey
>
> -----Original Message-----
> From: Colin King <colin.king@canonical.com>
> Sent: Tuesday, January 14, 2020 9:41 AM
> To: Corey Minyard <cminyard@mvista.com>; Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Vadim Pasternak <vadimp@mellanox.com>; Asmaa Mnebhi <Asmaa@mellanox.com>; openipmi-developer@lists.sourceforge.net
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The end of buffer check is off-by-one since the check is against an index that is pre-incremented before a store to buf[]. Fix this adjusting the bounds check appropriately.
>
> Addresses-Coverity: ("Out-of-bounds write")
> Fixes: 51bd6f291583 ("Add support for IPMB driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/ipmi/ipmb_dev_int.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
> index 9fdae83e59e0..382b28f1cf2f 100644
> --- a/drivers/char/ipmi/ipmb_dev_int.c
> +++ b/drivers/char/ipmi/ipmb_dev_int.c
> @@ -279,7 +279,7 @@ static int ipmb_slave_cb(struct i2c_client *client,
> break;
>
> case I2C_SLAVE_WRITE_RECEIVED:
> - if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg))
> + if (ipmb_dev->msg_idx >= sizeof(struct ipmb_msg) - 1)
> break;
>
> buf[++ipmb_dev->msg_idx] = *val;
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 17:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 14:40 [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write Colin King
2020-01-14 15:50 ` Asmaa Mnebhi
2020-01-20 17:01 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).