* [PATCH] xfrm: interface: do not confirm neighbor when do pmtu update
@ 2020-01-13 9:00 Xu Wang
2020-01-15 9:57 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-01-13 9:00 UTC (permalink / raw)
To: davem, herbert, steffen.klassert; +Cc: netdev, linux-kernel
When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
we should not call dst_confirm_neigh() as there is no two-way communication.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
net/xfrm/xfrm_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 7ac1542..e732637 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -297,7 +297,7 @@ xfrmi_xmit2(struct sk_buff *skb, struct net_device *dev, struct flowi *fl)
mtu = dst_mtu(dst);
if (!skb->ignore_df && skb->len > mtu) {
- skb_dst_update_pmtu(skb, mtu);
+ skb_dst_update_pmtu_no_confirm(skb, mtu);
if (skb->protocol == htons(ETH_P_IPV6)) {
if (mtu < IPV6_MIN_MTU)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfrm: interface: do not confirm neighbor when do pmtu update
2020-01-13 9:00 [PATCH] xfrm: interface: do not confirm neighbor when do pmtu update Xu Wang
@ 2020-01-15 9:57 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2020-01-15 9:57 UTC (permalink / raw)
To: Xu Wang; +Cc: davem, herbert, netdev, linux-kernel
On Mon, Jan 13, 2020 at 09:00:36AM +0000, Xu Wang wrote:
> When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
> we should not call dst_confirm_neigh() as there is no two-way communication.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Patch applied to the ipsec tree, thanks a lot!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 9:00 [PATCH] xfrm: interface: do not confirm neighbor when do pmtu update Xu Wang
2020-01-15 9:57 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).