* [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t
@ 2020-01-15 20:02 Krzysztof Kozlowski
2020-01-15 20:02 ` [PATCH v3 2/3] i2c: pnx: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-15 20:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: Vladimir Zapolskiy, Sylvain Lemieux, Linus Walleij,
Arnd Bergmann, linux-i2c, linux-kernel, linux-arm-kernel,
Jean Delvare, Jarkko Nikula, Krzysztof Kozlowski
resource_size_t should be printed with its own size-independent format
to fix warnings when compiling on 64-bit platform (e.g. with
COMPILE_TEST):
drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’:
drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v2:
1. Remove parentheses around res->start.
Changes since v1:
1. Use %pap, not %pa[p].
---
drivers/i2c/busses/i2c-pmcmsp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c
index 4fde74eb34a7..5d89c7c1b3a8 100644
--- a/drivers/i2c/busses/i2c-pmcmsp.c
+++ b/drivers/i2c/busses/i2c-pmcmsp.c
@@ -274,8 +274,8 @@ static int pmcmsptwi_probe(struct platform_device *pldev)
if (!request_mem_region(res->start, resource_size(res),
pldev->name)) {
dev_err(&pldev->dev,
- "Unable to get memory/io address region 0x%08x\n",
- res->start);
+ "Unable to get memory/io address region %pap\n",
+ &res->start);
rc = -EBUSY;
goto ret_err;
}
@@ -285,7 +285,7 @@ static int pmcmsptwi_probe(struct platform_device *pldev)
resource_size(res));
if (!pmcmsptwi_data.iobase) {
dev_err(&pldev->dev,
- "Unable to ioremap address 0x%08x\n", res->start);
+ "Unable to ioremap address %pap\n", &res->start);
rc = -EIO;
goto ret_unreserve;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/3] i2c: pnx: Use proper printk format for resource_size_t
2020-01-15 20:02 [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Krzysztof Kozlowski
@ 2020-01-15 20:02 ` Krzysztof Kozlowski
2020-01-15 20:11 ` Wolfram Sang
2020-01-15 20:02 ` [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t Krzysztof Kozlowski
2020-01-15 20:11 ` [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Wolfram Sang
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-15 20:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: Vladimir Zapolskiy, Sylvain Lemieux, Linus Walleij,
Arnd Bergmann, linux-i2c, linux-kernel, linux-arm-kernel,
Jean Delvare, Jarkko Nikula, Krzysztof Kozlowski
resource_size_t should be printed with its own size-independent format
to fix warnings when compiling on 64-bit platform (e.g. with
COMPILE_TEST):
drivers/i2c/busses/i2c-pnx.c: In function ‘i2c_pnx_probe’:
drivers/i2c/busses/i2c-pnx.c:737:47: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 5 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v2:
1. Remove parentheses around res->start.
Changes since v1:
1. Use %pap, not %pa[p].
---
drivers/i2c/busses/i2c-pnx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c
index 6e0e546ef83f..686c06f31625 100644
--- a/drivers/i2c/busses/i2c-pnx.c
+++ b/drivers/i2c/busses/i2c-pnx.c
@@ -734,8 +734,8 @@ static int i2c_pnx_probe(struct platform_device *pdev)
if (ret < 0)
goto out_clock;
- dev_dbg(&pdev->dev, "%s: Master at %#8x, irq %d.\n",
- alg_data->adapter.name, res->start, alg_data->irq);
+ dev_dbg(&pdev->dev, "%s: Master at %pap, irq %d.\n",
+ alg_data->adapter.name, &res->start, alg_data->irq);
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t
2020-01-15 20:02 [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Krzysztof Kozlowski
2020-01-15 20:02 ` [PATCH v3 2/3] i2c: pnx: " Krzysztof Kozlowski
@ 2020-01-15 20:02 ` Krzysztof Kozlowski
2020-01-15 20:11 ` Wolfram Sang
2020-01-15 20:11 ` [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Wolfram Sang
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-15 20:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: Vladimir Zapolskiy, Sylvain Lemieux, Linus Walleij,
Arnd Bergmann, linux-i2c, linux-kernel, linux-arm-kernel,
Jean Delvare, Jarkko Nikula, Krzysztof Kozlowski
size_t should be printed with its own format to be 64-bit friendly and
fix warning when compiling on 64-bit platform (e.g. with COMPILE_TEST):
drivers/i2c/busses/i2c-highlander.c: In function ‘highlander_i2c_smbus_xfer’:
drivers/i2c/busses/i2c-highlander.c:325:22: warning:
format ‘%d’ expects argument of type ‘int’,
but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v2:
1. Rewrite incorrect commit msg.
Changes since v1:
1. None
---
drivers/i2c/busses/i2c-highlander.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c
index abfe3094c047..803dad70e2a7 100644
--- a/drivers/i2c/busses/i2c-highlander.c
+++ b/drivers/i2c/busses/i2c-highlander.c
@@ -322,7 +322,7 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr,
tmp |= (SMMR_MODE0 | SMMR_MODE1);
break;
default:
- dev_err(dev->dev, "unsupported xfer size %d\n", dev->buf_len);
+ dev_err(dev->dev, "unsupported xfer size %zu\n", dev->buf_len);
return -EINVAL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t
2020-01-15 20:02 [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Krzysztof Kozlowski
2020-01-15 20:02 ` [PATCH v3 2/3] i2c: pnx: " Krzysztof Kozlowski
2020-01-15 20:02 ` [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t Krzysztof Kozlowski
@ 2020-01-15 20:11 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-01-15 20:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vladimir Zapolskiy, Sylvain Lemieux, Linus Walleij,
Arnd Bergmann, linux-i2c, linux-kernel, linux-arm-kernel,
Jean Delvare, Jarkko Nikula
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Wed, Jan 15, 2020 at 09:02:48PM +0100, Krzysztof Kozlowski wrote:
> resource_size_t should be printed with its own size-independent format
> to fix warnings when compiling on 64-bit platform (e.g. with
> COMPILE_TEST):
>
> drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’:
> drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/3] i2c: pnx: Use proper printk format for resource_size_t
2020-01-15 20:02 ` [PATCH v3 2/3] i2c: pnx: " Krzysztof Kozlowski
@ 2020-01-15 20:11 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-01-15 20:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vladimir Zapolskiy, Sylvain Lemieux, Linus Walleij,
Arnd Bergmann, linux-i2c, linux-kernel, linux-arm-kernel,
Jean Delvare, Jarkko Nikula
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Wed, Jan 15, 2020 at 09:02:49PM +0100, Krzysztof Kozlowski wrote:
> resource_size_t should be printed with its own size-independent format
> to fix warnings when compiling on 64-bit platform (e.g. with
> COMPILE_TEST):
>
> drivers/i2c/busses/i2c-pnx.c: In function ‘i2c_pnx_probe’:
> drivers/i2c/busses/i2c-pnx.c:737:47: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 5 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t
2020-01-15 20:02 ` [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t Krzysztof Kozlowski
@ 2020-01-15 20:11 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-01-15 20:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vladimir Zapolskiy, Sylvain Lemieux, Linus Walleij,
Arnd Bergmann, linux-i2c, linux-kernel, linux-arm-kernel,
Jean Delvare, Jarkko Nikula
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Wed, Jan 15, 2020 at 09:02:50PM +0100, Krzysztof Kozlowski wrote:
> size_t should be printed with its own format to be 64-bit friendly and
> fix warning when compiling on 64-bit platform (e.g. with COMPILE_TEST):
>
> drivers/i2c/busses/i2c-highlander.c: In function ‘highlander_i2c_smbus_xfer’:
> drivers/i2c/busses/i2c-highlander.c:325:22: warning:
> format ‘%d’ expects argument of type ‘int’,
> but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-15 20:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 20:02 [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Krzysztof Kozlowski
2020-01-15 20:02 ` [PATCH v3 2/3] i2c: pnx: " Krzysztof Kozlowski
2020-01-15 20:11 ` Wolfram Sang
2020-01-15 20:02 ` [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t Krzysztof Kozlowski
2020-01-15 20:11 ` Wolfram Sang
2020-01-15 20:11 ` [PATCH v3 1/3] i2c: pmcmsp: Use proper printk format for resource_size_t Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).