linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Yangtao Li <tiny.windzz@gmail.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Stephen Boyd <sboyd@kernel.org>, Sasha Levin <sashal@kernel.org>,
	linux-clk@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 035/251] clk: dove: fix refcount leak in dove_clk_init()
Date: Thu, 16 Jan 2020 12:31:09 -0500	[thread overview]
Message-ID: <20200116173445.21385-35-sashal@kernel.org> (raw)
In-Reply-To: <20200116173445.21385-1-sashal@kernel.org>

From: Yangtao Li <tiny.windzz@gmail.com>

[ Upstream commit 8d726c5128298386b907963033be93407b0c4275 ]

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Fixes: 8f7fc5450b64 ("clk: mvebu: dove: maintain clock init order")
Fixes: 63b8d92c793f ("clk: add Dove PLL divider support for GPU, VMeta and AXI clocks")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/clk/mvebu/dove.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mvebu/dove.c b/drivers/clk/mvebu/dove.c
index 59fad9546c84..5f258c9bb68b 100644
--- a/drivers/clk/mvebu/dove.c
+++ b/drivers/clk/mvebu/dove.c
@@ -190,10 +190,14 @@ static void __init dove_clk_init(struct device_node *np)
 
 	mvebu_coreclk_setup(np, &dove_coreclks);
 
-	if (ddnp)
+	if (ddnp) {
 		dove_divider_clk_init(ddnp);
+		of_node_put(ddnp);
+	}
 
-	if (cgnp)
+	if (cgnp) {
 		mvebu_clk_gating_setup(cgnp, dove_gating_desc);
+		of_node_put(cgnp);
+	}
 }
 CLK_OF_DECLARE(dove_clk, "marvell,dove-core-clock", dove_clk_init);
-- 
2.20.1


  parent reply	other threads:[~2020-01-16 17:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 17:30 [PATCH AUTOSEL 4.9 001/251] drm/sti: do not remove the drm_bridge that was never added Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 002/251] drm/virtio: fix bounds check in virtio_gpu_cmd_get_capset() Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 003/251] ALSA: hda: fix unused variable warning Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 004/251] IB/rxe: replace kvfree with vfree Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 005/251] regulator: fixed: Default enable high on DT regulators Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 006/251] ALSA: usb-audio: update quirk for B&W PX to remove microphone Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 007/251] staging: comedi: ni_mio_common: protect register write overflow Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 008/251] pwm: lpss: Release runtime-pm reference from the driver's remove callback Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 009/251] mlxsw: reg: QEEC: Add minimum shaper fields Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 010/251] pcrypt: use format specifier in kobject_add Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 011/251] exportfs: fix 'passing zero to ERR_PTR()' warning Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 012/251] drm/dp_mst: Skip validating ports during destruction, just ref Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 013/251] net: phy: Fix not to call phy_resume() if PHY is not attached Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 014/251] pinctrl: sh-pfc: r8a7740: Add missing REF125CK pin to gether_gmii group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 015/251] pinctrl: sh-pfc: r8a7740: Add missing LCD0 marks to lcd0_data24_1 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 016/251] pinctrl: sh-pfc: r8a7791: Remove bogus ctrl marks from qspi_data4_b group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 017/251] pinctrl: sh-pfc: r8a7791: Remove bogus marks from vin1_b_data18 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 018/251] pinctrl: sh-pfc: sh73a0: Add missing TO pin to tpu4_to3 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 019/251] pinctrl: sh-pfc: r8a7794: Remove bogus IPSR9 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 020/251] pinctrl: sh-pfc: sh7734: Add missing IPSR11 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 021/251] pinctrl: sh-pfc: sh7269: Add missing PCIOR0 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 022/251] pinctrl: sh-pfc: sh7734: Remove bogus IPSR10 value Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 023/251] Input: nomadik-ske-keypad - fix a loop timeout test Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 024/251] clk: highbank: fix refcount leak in hb_clk_init() Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 025/251] clk: qoriq: fix refcount leak in clockgen_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 026/251] clk: socfpga: fix refcount leak Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 027/251] clk: samsung: exynos4: fix refcount leak in exynos4_get_xom() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 028/251] clk: imx6q: fix refcount leak in imx6q_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 029/251] clk: imx6sx: fix refcount leak in imx6sx_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 030/251] clk: imx7d: fix refcount leak in imx7d_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 031/251] clk: vf610: fix refcount leak in vf610_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 032/251] clk: armada-370: fix refcount leak in a370_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 033/251] clk: kirkwood: fix refcount leak in kirkwood_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 034/251] clk: armada-xp: fix refcount leak in axp_clk_init() Sasha Levin
2020-01-16 17:31 ` Sasha Levin [this message]
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 036/251] IB/usnic: Fix out of bounds index check in query pkey Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 037/251] RDMA/ocrdma: " Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 038/251] RDMA/qedr: " Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 039/251] arm64: dts: apq8016-sbc: Increase load on l11 for SDCARD Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116173445.21385-35-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiny.windzz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).