linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Nicolas Huaman <nicolas@herochao.de>,
	Takashi Iwai <tiwai@suse.de>, Sasha Levin <sashal@kernel.org>,
	alsa-devel@alsa-project.org
Subject: [PATCH AUTOSEL 4.9 006/251] ALSA: usb-audio: update quirk for B&W PX to remove microphone
Date: Thu, 16 Jan 2020 12:30:40 -0500	[thread overview]
Message-ID: <20200116173445.21385-6-sashal@kernel.org> (raw)
In-Reply-To: <20200116173445.21385-1-sashal@kernel.org>

From: Nicolas Huaman <nicolas@herochao.de>

[ Upstream commit c369c8db15d51fa175d2ba85928f79d16af6b562 ]

A quirk in snd-usb-audio was added to automate setting sample rate to
4800k and remove the previously exposed nonfunctional microphone for
the Bowers & Wilkins PX:
commit 240a8af929c7c57dcde28682725b29cf8474e8e5
https://lore.kernel.org/patchwork/patch/919689/

However the headphones where updated shortly after that to remove the
unintentional microphone functionality. I guess because of this the
headphones now crash when connecting them via USB while the quirk is
active. Dmesg:

snd-usb-audio: probe of 2-3:1.0 failed with error -22
usb 2-3: 2:1: cannot get min/max values for control 2 (id 2)

This patch removes the microfone and allows the headphones to connect
and work out of the box. It is based on the current mainline kernel
 and successfully applied an tested on my machine (4.18.10.arch1-1).

Fixes: 240a8af929c7 ("ALSA: usb-audio: Add a quirck for B&W PX headphones")
Signed-off-by: Nicolas Huaman <nicolas@herochao.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 sound/usb/quirks-table.h | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index d32727c74a16..c892b4d1e733 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -3293,19 +3293,14 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
 				.ifnum = 0,
 				.type = QUIRK_AUDIO_STANDARD_MIXER,
 			},
-			/* Capture */
-			{
-				.ifnum = 1,
-				.type = QUIRK_IGNORE_INTERFACE,
-			},
 			/* Playback */
 			{
-				.ifnum = 2,
+				.ifnum = 1,
 				.type = QUIRK_AUDIO_FIXED_ENDPOINT,
 				.data = &(const struct audioformat) {
 					.formats = SNDRV_PCM_FMTBIT_S16_LE,
 					.channels = 2,
-					.iface = 2,
+					.iface = 1,
 					.altsetting = 1,
 					.altset_idx = 1,
 					.attributes = UAC_EP_CS_ATTR_FILL_MAX |
-- 
2.20.1


  parent reply	other threads:[~2020-01-16 17:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 17:30 [PATCH AUTOSEL 4.9 001/251] drm/sti: do not remove the drm_bridge that was never added Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 002/251] drm/virtio: fix bounds check in virtio_gpu_cmd_get_capset() Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 003/251] ALSA: hda: fix unused variable warning Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 004/251] IB/rxe: replace kvfree with vfree Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 005/251] regulator: fixed: Default enable high on DT regulators Sasha Levin
2020-01-16 17:30 ` Sasha Levin [this message]
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 007/251] staging: comedi: ni_mio_common: protect register write overflow Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 008/251] pwm: lpss: Release runtime-pm reference from the driver's remove callback Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 009/251] mlxsw: reg: QEEC: Add minimum shaper fields Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 010/251] pcrypt: use format specifier in kobject_add Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 011/251] exportfs: fix 'passing zero to ERR_PTR()' warning Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 012/251] drm/dp_mst: Skip validating ports during destruction, just ref Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 013/251] net: phy: Fix not to call phy_resume() if PHY is not attached Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 014/251] pinctrl: sh-pfc: r8a7740: Add missing REF125CK pin to gether_gmii group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 015/251] pinctrl: sh-pfc: r8a7740: Add missing LCD0 marks to lcd0_data24_1 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 016/251] pinctrl: sh-pfc: r8a7791: Remove bogus ctrl marks from qspi_data4_b group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 017/251] pinctrl: sh-pfc: r8a7791: Remove bogus marks from vin1_b_data18 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 018/251] pinctrl: sh-pfc: sh73a0: Add missing TO pin to tpu4_to3 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 019/251] pinctrl: sh-pfc: r8a7794: Remove bogus IPSR9 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 020/251] pinctrl: sh-pfc: sh7734: Add missing IPSR11 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 021/251] pinctrl: sh-pfc: sh7269: Add missing PCIOR0 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 022/251] pinctrl: sh-pfc: sh7734: Remove bogus IPSR10 value Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 023/251] Input: nomadik-ske-keypad - fix a loop timeout test Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 024/251] clk: highbank: fix refcount leak in hb_clk_init() Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 025/251] clk: qoriq: fix refcount leak in clockgen_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 026/251] clk: socfpga: fix refcount leak Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 027/251] clk: samsung: exynos4: fix refcount leak in exynos4_get_xom() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 028/251] clk: imx6q: fix refcount leak in imx6q_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 029/251] clk: imx6sx: fix refcount leak in imx6sx_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 030/251] clk: imx7d: fix refcount leak in imx7d_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 031/251] clk: vf610: fix refcount leak in vf610_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 032/251] clk: armada-370: fix refcount leak in a370_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 033/251] clk: kirkwood: fix refcount leak in kirkwood_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 034/251] clk: armada-xp: fix refcount leak in axp_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 035/251] clk: dove: fix refcount leak in dove_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 036/251] IB/usnic: Fix out of bounds index check in query pkey Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 037/251] RDMA/ocrdma: " Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 038/251] RDMA/qedr: " Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 039/251] arm64: dts: apq8016-sbc: Increase load on l11 for SDCARD Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116173445.21385-6-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas@herochao.de \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).