* [PATCH -next] cifs: remove set but not used variable 'server'
@ 2020-01-17 2:57 YueHaibing
2020-01-17 7:53 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-01-17 2:57 UTC (permalink / raw)
To: sfrench, pshilov, lsahlber
Cc: linux-cifs, samba-technical, linux-kernel, YueHaibing
fs/cifs/smb2pdu.c: In function 'SMB2_query_directory':
fs/cifs/smb2pdu.c:4444:26: warning:
variable 'server' set but not used [-Wunused-but-set-variable]
struct TCP_Server_Info *server;
It is not used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/cifs/smb2pdu.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index a23ca3d..64d5a36 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -4441,13 +4441,10 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon,
int resp_buftype = CIFS_NO_BUFFER;
struct kvec rsp_iov;
int rc = 0;
- struct TCP_Server_Info *server;
struct cifs_ses *ses = tcon->ses;
int flags = 0;
- if (ses && (ses->server))
- server = ses->server;
- else
+ if (!ses || !(ses->server))
return -EIO;
if (smb3_encryption_required(tcon))
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] cifs: remove set but not used variable 'server'
2020-01-17 2:57 [PATCH -next] cifs: remove set but not used variable 'server' YueHaibing
@ 2020-01-17 7:53 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2020-01-17 7:53 UTC (permalink / raw)
To: YueHaibing
Cc: Steve French, Pavel Shilovskiy, Ronnie Sahlberg, CIFS,
samba-technical, LKML
merged into cifs-2.6.git for-next
On Thu, Jan 16, 2020 at 10:01 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> fs/cifs/smb2pdu.c: In function 'SMB2_query_directory':
> fs/cifs/smb2pdu.c:4444:26: warning:
> variable 'server' set but not used [-Wunused-but-set-variable]
> struct TCP_Server_Info *server;
>
> It is not used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/cifs/smb2pdu.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index a23ca3d..64d5a36 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -4441,13 +4441,10 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon,
> int resp_buftype = CIFS_NO_BUFFER;
> struct kvec rsp_iov;
> int rc = 0;
> - struct TCP_Server_Info *server;
> struct cifs_ses *ses = tcon->ses;
> int flags = 0;
>
> - if (ses && (ses->server))
> - server = ses->server;
> - else
> + if (!ses || !(ses->server))
> return -EIO;
>
> if (smb3_encryption_required(tcon))
> --
> 2.7.4
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-17 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 2:57 [PATCH -next] cifs: remove set but not used variable 'server' YueHaibing
2020-01-17 7:53 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).