* [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
@ 2020-01-18 15:24 Emmanuel Vadot
2020-01-21 9:10 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Emmanuel Vadot @ 2020-01-18 15:24 UTC (permalink / raw)
To: mripard, wens, robh+dt, mark.rutland
Cc: linux-arm-kernel, devicetree, linux-kernel, Emmanuel Vadot
From: Emmanuel Vadot <manu@freebsd.org>
Add the regulators for each bank on this boards.
For VCC-PL only add a comment on what regulator is used. We cannot add
the property without causing a circular dependency as the PL pins are
used to talk to the PMIC.
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
v2:
- Remove vcc-pl-supply in r_pio as it cause a circular dependency.
.../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..7e71b5b12f98 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,17 @@ &ohci1 {
status = "okay";
};
+&pio {
+ vcc-pa-supply = <®_dcdc1>;
+ vcc-pb-supply = <®_dcdc1>;
+ vcc-pc-supply = <®_dcdc1>;
+ vcc-pd-supply = <®_dcdc1>;
+ vcc-pe-supply = <®_aldo1>;
+ vcc-pf-supply = <®_dcdc1>;
+ vcc-pg-supply = <®_dldo4>;
+ vcc-ph-supply = <®_dcdc1>;
+};
+
&r_rsb {
status = "okay";
@@ -175,6 +186,12 @@ axp803: pmic@3a3 {
};
};
+/* VCC-PL is powered by aldo2 but we cannot add it as the RSB */
+/* interface used to talk to the PMIC in on the PL pins */
+/* &r_pio { */
+/* vcc-pl-supply = <®_aldo2>; */
+/* }; */
+
#include "axp803.dtsi"
&ac_power_supply {
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
2020-01-18 15:24 [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino Emmanuel Vadot
@ 2020-01-21 9:10 ` Maxime Ripard
2020-01-21 11:07 ` Emmanuel Vadot
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2020-01-21 9:10 UTC (permalink / raw)
To: Emmanuel Vadot
Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
Hi,
On Sat, Jan 18, 2020 at 04:24:59PM +0100, Emmanuel Vadot wrote:
> From: Emmanuel Vadot <manu@freebsd.org>
>
> Add the regulators for each bank on this boards.
> For VCC-PL only add a comment on what regulator is used. We cannot add
> the property without causing a circular dependency as the PL pins are
> used to talk to the PMIC.
>
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
It seems that you sent it twice?
I applied the second. It was not applying properly though, make sure
to base your patches on next.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
2020-01-21 9:10 ` Maxime Ripard
@ 2020-01-21 11:07 ` Emmanuel Vadot
0 siblings, 0 replies; 4+ messages in thread
From: Emmanuel Vadot @ 2020-01-21 11:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: Emmanuel Vadot, wens, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel
On Tue, 21 Jan 2020 10:10:26 +0100
Maxime Ripard <mripard@kernel.org> wrote:
> Hi,
>
> On Sat, Jan 18, 2020 at 04:24:59PM +0100, Emmanuel Vadot wrote:
> > From: Emmanuel Vadot <manu@freebsd.org>
> >
> > Add the regulators for each bank on this boards.
> > For VCC-PL only add a comment on what regulator is used. We cannot add
> > the property without causing a circular dependency as the PL pins are
> > used to talk to the PMIC.
> >
> > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
>
> It seems that you sent it twice?
Yes sorry mail server hickups.
> I applied the second. It was not applying properly though, make sure
> to base your patches on next.
Ah right, sorry again, I've used master, will use next the next time.
Thanks.
> Maxime
--
Emmanuel Vadot <manu@bidouilliste.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
@ 2020-01-18 14:34 Emmanuel Vadot
0 siblings, 0 replies; 4+ messages in thread
From: Emmanuel Vadot @ 2020-01-18 14:34 UTC (permalink / raw)
To: mripard, wens, robh+dt, mark.rutland
Cc: linux-arm-kernel, devicetree, linux-kernel, Emmanuel Vadot
Add the regulators for each bank on this boards.
For VCC-PL only add a comment on what regulator is used. We cannot add
the property without causing a circular dependency as the PL pins are
used to talk to the PMIC.
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
v2:
- Remove vcc-pl-supply in r_pio as it cause a circular dependency.
.../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..7e71b5b12f98 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,17 @@ &ohci1 {
status = "okay";
};
+&pio {
+ vcc-pa-supply = <®_dcdc1>;
+ vcc-pb-supply = <®_dcdc1>;
+ vcc-pc-supply = <®_dcdc1>;
+ vcc-pd-supply = <®_dcdc1>;
+ vcc-pe-supply = <®_aldo1>;
+ vcc-pf-supply = <®_dcdc1>;
+ vcc-pg-supply = <®_dldo4>;
+ vcc-ph-supply = <®_dcdc1>;
+};
+
&r_rsb {
status = "okay";
@@ -175,6 +186,12 @@ axp803: pmic@3a3 {
};
};
+/* VCC-PL is powered by aldo2 but we cannot add it as the RSB */
+/* interface used to talk to the PMIC in on the PL pins */
+/* &r_pio { */
+/* vcc-pl-supply = <®_aldo2>; */
+/* }; */
+
#include "axp803.dtsi"
&ac_power_supply {
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-21 11:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 15:24 [PATCH v2] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino Emmanuel Vadot
2020-01-21 9:10 ` Maxime Ripard
2020-01-21 11:07 ` Emmanuel Vadot
-- strict thread matches above, loose matches on Subject: below --
2020-01-18 14:34 Emmanuel Vadot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).