* [PATCH] net: phy: adin: fix a warning about msleep
@ 2020-01-17 15:10 Dejin Zheng
2020-01-19 15:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dejin Zheng @ 2020-01-17 15:10 UTC (permalink / raw)
To: alexaundru.ardelean, andrew, f.fainelli, hkallweit1, davem, netdev
Cc: linux-kernel, Dejin Zheng
found a warning by the following command:
./scripts/checkpatch.pl -f drivers/net/phy/adin.c
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#628: FILE: drivers/net/phy/adin.c:628:
+ msleep(10);
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
drivers/net/phy/adin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index cf5a391c93e6..6de25a2d3a05 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -625,7 +625,7 @@ static int adin_soft_reset(struct phy_device *phydev)
if (rc < 0)
return rc;
- msleep(10);
+ msleep(20);
/* If we get a read error something may be wrong */
rc = phy_read_mmd(phydev, MDIO_MMD_VEND1,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: adin: fix a warning about msleep
2020-01-17 15:10 [PATCH] net: phy: adin: fix a warning about msleep Dejin Zheng
@ 2020-01-19 15:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-19 15:07 UTC (permalink / raw)
To: zhengdejin5
Cc: alexaundru.ardelean, andrew, f.fainelli, hkallweit1, netdev,
linux-kernel
From: Dejin Zheng <zhengdejin5@gmail.com>
Date: Fri, 17 Jan 2020 23:10:42 +0800
> found a warning by the following command:
> ./scripts/checkpatch.pl -f drivers/net/phy/adin.c
>
> WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
> #628: FILE: drivers/net/phy/adin.c:628:
> + msleep(10);
>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Not critical, so applied to net-next.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-19 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 15:10 [PATCH] net: phy: adin: fix a warning about msleep Dejin Zheng
2020-01-19 15:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).