From: Samuel Holland <samuel@sholland.org>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Samuel Holland <samuel@sholland.org>
Subject: [PATCH 8/9] arm64: dts: allwinner: pinebook: Fix backlight regulator
Date: Sun, 19 Jan 2020 10:31:03 -0600 [thread overview]
Message-ID: <20200119163104.13274-8-samuel@sholland.org> (raw)
In-Reply-To: <20200119163104.13274-1-samuel@sholland.org>
The output from the backlight regulator is labeled as "VBKLT" in the
schematic. Using the equation and resistor values from the schematic,
the output is approximately 18V, not 3.3V. Since the regulator in use
(SS6640STR) is a boost regulator powered by PS (battery or AC input),
which are both >3.3V, the output could not be 3.3V anyway.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
.../dts/allwinner/sun50i-a64-pinebook.dts | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
index 3e762f93671a..96434fdeb5c0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
@@ -21,22 +21,13 @@
ethernet0 = &rtl8723cs;
};
- vdd_bl: regulator@0 {
- compatible = "regulator-fixed";
- regulator-name = "bl-3v3";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */
- enable-active-high;
- };
-
backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 50000 0>;
brightness-levels = <0 5 10 15 20 30 40 55 70 85 100>;
default-brightness-level = <2>;
enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* PD23 */
- power-supply = <&vdd_bl>;
+ power-supply = <®_vbklt>;
};
chosen {
@@ -57,6 +48,15 @@
};
};
+ reg_vbklt: vbklt {
+ compatible = "regulator-fixed";
+ regulator-name = "vbklt";
+ regulator-min-microvolt = <18000000>;
+ regulator-max-microvolt = <18000000>;
+ gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */
+ enable-active-high;
+ };
+
wifi_pwrseq: wifi_pwrseq {
compatible = "mmc-pwrseq-simple";
reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
--
2.23.0
next prev parent reply other threads:[~2020-01-19 16:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 16:30 [PATCH 1/9] arm64: dts: allwinner: Enable button wakeup on Orange Pi PC2 Samuel Holland
2020-01-19 16:30 ` [PATCH 2/9] arm64: dts: allwinner: pinebook: Remove unused vcc3v3 regulator Samuel Holland
2020-01-21 9:04 ` Maxime Ripard
2020-01-19 16:30 ` [PATCH 3/9] arm64: dts: allwinner: pinebook: Remove unused AXP803 regulators Samuel Holland
2020-01-21 9:05 ` Maxime Ripard
2020-01-21 18:49 ` Vasily Khoruzhick
2020-01-22 3:14 ` Samuel Holland
2020-01-24 16:33 ` Maxime Ripard
2020-01-24 23:11 ` Vasily Khoruzhick
2020-02-14 15:03 ` Maxime Ripard
2020-01-19 16:30 ` [PATCH 4/9] arm64: dts: allwinner: pinebook: Sort device tree nodes Samuel Holland
2020-01-21 9:06 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 5/9] arm64: dts: allwinner: pinebook: Make simplefb more consistent Samuel Holland
2020-01-21 9:06 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 6/9] arm64: dts: allwinner: pinebook: Document MMC0 CD pin name Samuel Holland
2020-01-21 9:06 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 7/9] arm64: dts: allwinner: pinebook: Add GPIO port regulators Samuel Holland
2020-01-21 9:07 ` Maxime Ripard
2020-01-19 16:31 ` Samuel Holland [this message]
2020-01-21 9:07 ` [PATCH 8/9] arm64: dts: allwinner: pinebook: Fix backlight regulator Maxime Ripard
2020-01-19 16:31 ` [PATCH 9/9] arm64: dts: allwinner: pinebook: Fix 5v0 boost regulator Samuel Holland
2020-01-21 9:08 ` Maxime Ripard
2020-01-21 9:03 ` [PATCH 1/9] arm64: dts: allwinner: Enable button wakeup on Orange Pi PC2 Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119163104.13274-8-samuel@sholland.org \
--to=samuel@sholland.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).