From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Rob Herring <robh+dt@kernel.org>,
arm-linux <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/9] arm64: dts: allwinner: pinebook: Remove unused AXP803 regulators
Date: Tue, 21 Jan 2020 10:49:37 -0800 [thread overview]
Message-ID: <CA+E=qVcdza_E17_=r+0eZ2UexCYah35jt8=v+uFTLHx3+BvHSg@mail.gmail.com> (raw)
In-Reply-To: <20200121090539.mgswdzfharrfy5ad@gilmour.lan>
On Tue, Jan 21, 2020 at 1:05 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> On Sun, Jan 19, 2020 at 10:30:58AM -0600, Samuel Holland wrote:
> > The Pinebook does not use the CSI bus on the A64. In fact it does not
> > use GPIO port E for anything at all. Thus the following regulators are
> > not used and do not need voltages set:
> >
> > - ALDO1: Connected to VCC-PE only
> > - DLDO3: Not connected
> > - ELDO3: Not connected
> >
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 16 +---------------
> > 1 file changed, 1 insertion(+), 15 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> > index ff32ca1a495e..8e7ce6ad28dd 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> > @@ -202,9 +202,7 @@
> > };
> >
> > ®_aldo1 {
> > - regulator-min-microvolt = <2800000>;
> > - regulator-max-microvolt = <2800000>;
> > - regulator-name = "vcc-csi";
> > + regulator-name = "vcc-pe";
> > };
>
> If it's connected to PE, I'd expect the voltage to be at 3.3v?
Commit message says that PE is not used, so we don't need to set it at all.
> Maxime
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-21 18:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 16:30 [PATCH 1/9] arm64: dts: allwinner: Enable button wakeup on Orange Pi PC2 Samuel Holland
2020-01-19 16:30 ` [PATCH 2/9] arm64: dts: allwinner: pinebook: Remove unused vcc3v3 regulator Samuel Holland
2020-01-21 9:04 ` Maxime Ripard
2020-01-19 16:30 ` [PATCH 3/9] arm64: dts: allwinner: pinebook: Remove unused AXP803 regulators Samuel Holland
2020-01-21 9:05 ` Maxime Ripard
2020-01-21 18:49 ` Vasily Khoruzhick [this message]
2020-01-22 3:14 ` Samuel Holland
2020-01-24 16:33 ` Maxime Ripard
2020-01-24 23:11 ` Vasily Khoruzhick
2020-02-14 15:03 ` Maxime Ripard
2020-01-19 16:30 ` [PATCH 4/9] arm64: dts: allwinner: pinebook: Sort device tree nodes Samuel Holland
2020-01-21 9:06 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 5/9] arm64: dts: allwinner: pinebook: Make simplefb more consistent Samuel Holland
2020-01-21 9:06 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 6/9] arm64: dts: allwinner: pinebook: Document MMC0 CD pin name Samuel Holland
2020-01-21 9:06 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 7/9] arm64: dts: allwinner: pinebook: Add GPIO port regulators Samuel Holland
2020-01-21 9:07 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 8/9] arm64: dts: allwinner: pinebook: Fix backlight regulator Samuel Holland
2020-01-21 9:07 ` Maxime Ripard
2020-01-19 16:31 ` [PATCH 9/9] arm64: dts: allwinner: pinebook: Fix 5v0 boost regulator Samuel Holland
2020-01-21 9:08 ` Maxime Ripard
2020-01-21 9:03 ` [PATCH 1/9] arm64: dts: allwinner: Enable button wakeup on Orange Pi PC2 Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+E=qVcdza_E17_=r+0eZ2UexCYah35jt8=v+uFTLHx3+BvHSg@mail.gmail.com' \
--to=anarsoul@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).