linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: keystone: Fix error handling when "num-viewport" DT property is not populated
@ 2020-01-21 11:57 Kishon Vijay Abraham I
  2020-01-21 16:52 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2020-01-21 11:57 UTC (permalink / raw)
  To: Murali Karicheri, Lorenzo Pieralisi, Andrew Murray, Bjorn Helgaas
  Cc: linux-pci, linux-arm-kernel, linux-kernel, Kishon Vijay Abraham I

Fix error handling when "num-viewport" DT property is not populated.

Fixes: 23284ad677a94 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/controller/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index dbe31589eb61..2c127c321080 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -1357,7 +1357,7 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
 		ret = of_property_read_u32(np, "num-viewport", &num_viewport);
 		if (ret < 0) {
 			dev_err(dev, "unable to read *num-viewport* property\n");
-			return ret;
+			goto err_get_sync;
 		}
 
 		/*
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: keystone: Fix error handling when "num-viewport" DT property is not populated
  2020-01-21 11:57 [PATCH] PCI: keystone: Fix error handling when "num-viewport" DT property is not populated Kishon Vijay Abraham I
@ 2020-01-21 16:52 ` Lorenzo Pieralisi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2020-01-21 16:52 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Murali Karicheri, Andrew Murray, Bjorn Helgaas, linux-pci,
	linux-arm-kernel, linux-kernel

On Tue, Jan 21, 2020 at 05:27:34PM +0530, Kishon Vijay Abraham I wrote:
> Fix error handling when "num-viewport" DT property is not populated.
> 
> Fixes: 23284ad677a94 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms")
> Cc: stable@vger.kernel.org # v5.2+
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/controller/dwc/pci-keystone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/keystone, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index dbe31589eb61..2c127c321080 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -1357,7 +1357,7 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
>  		ret = of_property_read_u32(np, "num-viewport", &num_viewport);
>  		if (ret < 0) {
>  			dev_err(dev, "unable to read *num-viewport* property\n");
> -			return ret;
> +			goto err_get_sync;
>  		}
>  
>  		/*
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-21 16:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 11:57 [PATCH] PCI: keystone: Fix error handling when "num-viewport" DT property is not populated Kishon Vijay Abraham I
2020-01-21 16:52 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).