From: Wei Yang <richardw.yang@linux.intel.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rientjes@google.com
Subject: Re: [Patch v2 4/4] mm/page_alloc.c: extract commom part to check page
Date: Wed, 22 Jan 2020 09:00:24 +0800 [thread overview]
Message-ID: <20200122010024.GF11409@richard> (raw)
In-Reply-To: <c4abbe4d-6777-6c06-2a47-e01585b12745@arm.com>
On Tue, Jan 21, 2020 at 10:19:38AM +0530, Anshuman Khandual wrote:
>
>
>On 01/20/2020 06:06 PM, Wei Yang wrote:
>> On Mon, Jan 20, 2020 at 12:13:38PM +0530, Anshuman Khandual wrote:
>>>
>>>
>>> On 01/20/2020 08:34 AM, Wei Yang wrote:
>>>> During free and new page, we did some check on the status of page
>>>> struct. There is some common part, just extract them.
>>>
>>> Makes sense.
>>>
>>>>
>>>> Besides this, this patch also rename two functions to keep the name
>>>> convention, since free_pages_check_bad/free_pages_check are counterparts
>>>> of check_new_page_bad/check_new_page.
>>>
>>> This probably should be in a different patch.
>>>
>>
>> In v1, they are in two separate patches. While David Suggest to merge it.
>>
>> I am not sure whether my understanding is correct.
>
>Keeping code refactoring and renaming separate is always better
>but its okay, will leave it upto you.
>
Agree with you :-)
Maybe I misunderstand David. Will split it in next version.
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2020-01-22 1:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 3:04 [Patch v2 0/4] mm/page_alloc.c: cleanup on check page Wei Yang
2020-01-20 3:04 ` [Patch v2 1/4] mm: enable dump several reasons for __dump_page() Wei Yang
2020-01-20 6:12 ` Anshuman Khandual
2020-01-20 8:55 ` Wei Yang
2020-01-21 5:20 ` Anshuman Khandual
2020-01-22 0:58 ` Wei Yang
2020-01-26 2:44 ` Wei Yang
2020-01-20 3:04 ` [Patch v2 2/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison Wei Yang
2020-01-20 6:28 ` Anshuman Khandual
2020-01-20 12:13 ` Wei Yang
2020-01-20 10:17 ` Michal Hocko
2020-01-20 12:20 ` David Hildenbrand
2020-01-20 3:04 ` [Patch v2 3/4] mm/page_alloc.c: pass all bad reasons to bad_page() Wei Yang
2020-01-20 6:33 ` Anshuman Khandual
2020-01-20 12:33 ` Wei Yang
2020-01-20 10:22 ` Michal Hocko
2020-01-20 12:19 ` David Hildenbrand
2020-01-21 1:49 ` Wei Yang
2020-01-21 6:08 ` Anshuman Khandual
2020-01-21 8:47 ` Michal Hocko
2020-01-20 3:04 ` [Patch v2 4/4] mm/page_alloc.c: extract commom part to check page Wei Yang
2020-01-20 6:43 ` Anshuman Khandual
2020-01-20 12:36 ` Wei Yang
2020-01-21 4:49 ` Anshuman Khandual
2020-01-22 1:00 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122010024.GF11409@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).