* [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines
@ 2020-01-21 19:52 Sandesh Kenjana Ashok
2020-01-22 8:17 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Sandesh Kenjana Ashok @ 2020-01-21 19:52 UTC (permalink / raw)
To: Greg Kroah-Hartman, Matthias Brugger
Cc: devel, linux-arm-kernel, linux-mediatek, linux-kernel
Cleanup lines over 80 characters in pinctrl-rt2880.c.
Issue found by checkpatch.pl
Signed-off-by: Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com>
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
index d0f06790d38f..254d4eb88f5f 100644
--- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
+++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
@@ -159,8 +159,8 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev,
}
static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev,
- struct pinctrl_gpio_range *range,
- unsigned int pin)
+ struct pinctrl_gpio_range *range,
+ unsigned int pin)
{
struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines
2020-01-21 19:52 [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines Sandesh Kenjana Ashok
@ 2020-01-22 8:17 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2020-01-22 8:17 UTC (permalink / raw)
To: Sandesh Kenjana Ashok
Cc: Greg Kroah-Hartman, Matthias Brugger, devel, linux-mediatek,
linux-kernel, linux-arm-kernel
On Tue, Jan 21, 2020 at 08:52:18PM +0100, Sandesh Kenjana Ashok wrote:
> Cleanup lines over 80 characters in pinctrl-rt2880.c.
> Issue found by checkpatch.pl
>
> Signed-off-by: Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com>
> ---
> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
> index d0f06790d38f..254d4eb88f5f 100644
> --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
> +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
> @@ -159,8 +159,8 @@ static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev,
> }
>
> static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev,
> - struct pinctrl_gpio_range *range,
> - unsigned int pin)
> + struct pinctrl_gpio_range *range,
> + unsigned int pin)
> {
> struct rt2880_priv *p = pinctrl_dev_get_drvdata(pctrldev);
Now it has a new warning.
CHECK: Alignment should match open parenthesis
#162: FILE: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:162:
+static int rt2880_pmx_group_gpio_request_enable(struct pinctrl_dev *pctrldev,
+ struct pinctrl_gpio_range *range,
Just leave it. The original is fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 19:52 [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines Sandesh Kenjana Ashok
2020-01-22 8:17 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).